chore(ci): harden workflows, enforce zizmor - #85
Merged
Merged
Conversation
- Explicit read-only `permissions:` on workflows that had none (the org default is read-only already; this makes it visible and drops read access to other scopes). - Checkouts that never push no longer leave the token in .git/config (`persist-credentials: false`); ones that push say so explicitly. - Third-party actions SHA-pinned at the commits their tags point to today; Dependabot keeps them current. - dnb-robot app tokens scoped to what each job does instead of the app's whole grant. - No Actions caches in release/deploy jobs, where a cache written by another ref could end up in what gets published. - New zizmor job (reusable-actions zizmor.yml) gated by Required checks passed, so new findings block merges; accepted ones are in .github/zizmor.yml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
permissions:on workflows that had none. The org default is already read-only; this makes it visible and drops read access to other scopes..git/config. broker-audit, which opens a PR, keeps them explicitly.contents(publishing the release and pushing the cask to homebrew-tap).zizmor.yml), gated byRequired checks passed. The only accepted finding is the auto-mergeworkflow_runtrigger, in.github/zizmor.yml.Test plan
lowand above with this repo's own config