fix(dots-setup): record config template hash so chezmoi stops warning - #52
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chezmoi records .chezmoi.toml.tmpl's hash only during
chezmoi init, so after any template change it warns "config file template has changed" on every command, anddots-setupnever cleared it. Runningchezmoi initby hand is worse: it replaces the real config with the template's all-off defaults.dots-setupnow runschezmoi initright before it writes chezmoi.toml. That records the hash, and the wizard's config immediately overwrites the defaults. A failed init only warns, so it can't abort the script between the two writes.