Add JSON output to team commands with pagination support#286
Merged
Conversation
Add structured JSON output to team info, list-members, list-groups, add-member, and remove-member commands. Extract teamClient interface for testability, add full pagination to list-members and list-groups, and fix text output to use command writers instead of os.Stdout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--output=json) toteam info,team list-members,team list-groups,team add-member, andteam remove-memberteamClientinterface andteamNewFuncfactory for testabilitylist-membersandlist-groups(previously only returned the first page)os.StdoutjsonErrorCodematching from"requires a"to"requires "to cover team command argument errorsTest plan
go test ./cmd/...passes — new tests cover JSON output, pagination, text output, error paths, and structured output support for all 5 team commandsgolangci-lint run ./...passesdbxcli team info --output=jsonoutputs team metadata in operation formatdbxcli team list-members --output=jsonpaginates and returns all membersdbxcli team list-groups --output=jsonpaginates and returns all groupsdbxcli team add-member --output=jsonoutputs mutation result with launch statusdbxcli team remove-member --output=jsonoutputs mutation result with launch status