Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,7 @@ All `--sort`, `--reverse`, `--time`, and `--time-format` flags work with both `l

```sh
$ dbxcli share link create /file.txt # create or return an existing shared link
$ dbxcli share link update <url> --allow-download # update shared link settings
$ dbxcli share list link # list existing shared links
$ dbxcli share list folder # list shared folders
```
Expand Down
8 changes: 8 additions & 0 deletions cmd/share_create_link_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ import (
type mockSharedLinkClient struct {
createSharedLinkWithSettingsFn func(arg *sharing.CreateSharedLinkWithSettingsArg) (sharing.IsSharedLinkMetadata, error)
listSharedLinksFn func(arg *sharing.ListSharedLinksArg) (*sharing.ListSharedLinksResult, error)
modifySharedLinkSettingsFn func(arg *sharing.ModifySharedLinkSettingsArgs) (sharing.IsSharedLinkMetadata, error)
}

func (m *mockSharedLinkClient) CreateSharedLinkWithSettings(arg *sharing.CreateSharedLinkWithSettingsArg) (sharing.IsSharedLinkMetadata, error) {
Expand All @@ -45,6 +46,13 @@ func (m *mockSharedLinkClient) ListSharedLinks(arg *sharing.ListSharedLinksArg)
return &sharing.ListSharedLinksResult{}, nil
}

func (m *mockSharedLinkClient) ModifySharedLinkSettings(arg *sharing.ModifySharedLinkSettingsArgs) (sharing.IsSharedLinkMetadata, error) {
if m.modifySharedLinkSettingsFn != nil {
return m.modifySharedLinkSettingsFn(arg)
}
return nil, nil
}

func stubSharedLinkClient(t *testing.T, client sharedLinkClient) {
t.Helper()

Expand Down
1 change: 1 addition & 0 deletions cmd/share_link.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import (
type sharedLinkClient interface {
CreateSharedLinkWithSettings(arg *sharing.CreateSharedLinkWithSettingsArg) (sharing.IsSharedLinkMetadata, error)
ListSharedLinks(arg *sharing.ListSharedLinksArg) (*sharing.ListSharedLinksResult, error)
ModifySharedLinkSettings(arg *sharing.ModifySharedLinkSettingsArgs) (sharing.IsSharedLinkMetadata, error)
}

var newSharedLinkClient = func(cfg dropbox.Config) sharedLinkClient {
Expand Down
120 changes: 120 additions & 0 deletions cmd/share_link_update.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,120 @@
// Copyright © 2016 Dropbox, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package cmd

import (
"errors"
"fmt"
"time"

"github.com/dropbox/dropbox-sdk-go-unofficial/v6/dropbox/sharing"
"github.com/spf13/cobra"
)

type shareLinkUpdateOptions struct {
expires *time.Time
removeExpiration bool
allowDownload bool
}

func shareLinkUpdate(cmd *cobra.Command, args []string) error {
if len(args) != 1 {
return errors.New("`share link update` requires a `url` argument")
}

url := args[0]
if url == "" {
return errors.New("`share link update` requires a non-empty URL")
}

opts, err := parseShareLinkUpdateOptions(cmd)
if err != nil {
return err
}

settings := sharing.NewSharedLinkSettings()
if opts.expires != nil {
settings.Expires = opts.expires
}
if opts.allowDownload {
settings.AllowDownload = true
}

arg := sharing.NewModifySharedLinkSettingsArgs(url, settings)
arg.RemoveExpiration = opts.removeExpiration

dbx := newSharedLinkClient(config)
if _, err := dbx.ModifySharedLinkSettings(arg); err != nil {
return err
}

verbose, _ := cmd.Flags().GetBool("verbose")
if verbose {
commandOutput(cmd).Status("Updated shared link %s", url)
}

return nil
}

func parseShareLinkUpdateOptions(cmd *cobra.Command) (shareLinkUpdateOptions, error) {
expiresChanged := cmd.Flags().Changed("expires")
removeExpiration, err := cmd.Flags().GetBool("remove-expiration")
if err != nil {
return shareLinkUpdateOptions{}, err
}
allowDownload, err := cmd.Flags().GetBool("allow-download")
if err != nil {
return shareLinkUpdateOptions{}, err
}

if expiresChanged && removeExpiration {
return shareLinkUpdateOptions{}, errors.New("`--expires` and `--remove-expiration` cannot be used together")
}
if !expiresChanged && !removeExpiration && !allowDownload {
return shareLinkUpdateOptions{}, errors.New("at least one shared link setting flag is required")
}

var expires *time.Time
if expiresChanged {
value, err := cmd.Flags().GetString("expires")
if err != nil {
return shareLinkUpdateOptions{}, err
}
parsed, err := time.Parse(time.RFC3339, value)
if err != nil {
return shareLinkUpdateOptions{}, fmt.Errorf("invalid --expires %q: use RFC3339 timestamp", value)
}
expires = &parsed
}

return shareLinkUpdateOptions{
expires: expires,
removeExpiration: removeExpiration,
allowDownload: allowDownload,
}, nil
}

var shareLinkUpdateCmd = &cobra.Command{
Use: "update <url>",
Short: "Update shared link settings",
RunE: shareLinkUpdate,
}

func init() {
shareLinkUpdateCmd.Flags().String("expires", "", "Set shared link expiration time as an RFC3339 timestamp")
shareLinkUpdateCmd.Flags().Bool("remove-expiration", false, "Remove the shared link expiration time")
shareLinkUpdateCmd.Flags().Bool("allow-download", false, "Allow downloads from the shared link")
shareLinkCmd.AddCommand(shareLinkUpdateCmd)
}
Loading