Skip to content

Add current cue footer to live show view#1291

Merged
Tim020 merged 2 commits into
devfrom
feature/live-current-cue-footer
Jul 9, 2026
Merged

Add current cue footer to live show view#1291
Tim020 merged 2 commits into
devfrom
feature/live-current-cue-footer

Conversation

@Tim020

@Tim020 Tim020 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds a "Current Cues" footer below the script pane in the live show view, showing the last cue passed for every cue type (using the same badge styling as the script's cue column), updating as the script scrolls for both leader and follower clients.
  • Toggleable per user via a new Show current cue footer in Live view setting on the User Settings page (Settings tab), defaulting to on, synced via the existing PATCH + WS GET_USER_SETTINGS round-trip.
  • Fixes ScriptViewPane.vue's JS-computed pane height to account for the new footer (previously it claimed the entire viewport, which would have pushed the footer off-screen); wired a ResizeObserver + prop watcher so sizing stays correct as the footer grows or is toggled.

Test plan

  • pytest (server) — 704 passed
  • npm run typecheck / npm run lint (client-v3) — clean
  • npm run test:run (client-v3) — 39 passed, incl. new coverage for the cue-ordering store getters
  • npm run test:e2e (client-v3, full suite) — 221 passed, incl. new coverage for footer visibility (toBeInViewport), cue tracking, and settings persistence

🤖 Generated with Claude Code

Shows the last cue passed for every cue type in a footer below the script
pane, so the current cueing position stays visible without needing the
script's cue column in frame. Toggleable per user from User Settings.

Fixes the live script pane's JS-computed height so it accounts for the new
footer instead of claiming the full viewport and pushing it off-screen.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@Tim020 Tim020 added the claude Issues created by Claude label Jul 9, 2026
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

Client Test Results

132 tests   132 ✅  0s ⏱️
  7 suites    0 💤
  1 files      0 ❌

Results for commit 5d830b1.

♻️ This comment has been updated with latest results.

@github-actions github-actions Bot added documentation Improvements or additions to documentation server Pull requests changing back end code medium-diff client-v3 labels Jul 9, 2026
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

Client V3 Test Results

39 tests   39 ✅  0s ⏱️
 4 suites   0 💤
 1 files     0 ❌

Results for commit 5d830b1.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

Playwright E2E Results (firefox)

221 tests   221 ✅  2m 58s ⏱️
 14 suites    0 💤
  1 files      0 ❌

Results for commit 5d830b1.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

Playwright E2E Results (chromium)

221 tests   221 ✅  2m 19s ⏱️
 14 suites    0 💤
  1 files      0 ❌

Results for commit 5d830b1.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

Python Test Results

  1 files    1 suites   2m 16s ⏱️
704 tests 704 ✅ 0 💤 0 ❌
709 runs  709 ✅ 0 💤 0 ❌

Results for commit 5d830b1.

♻️ This comment has been updated with latest results.

Mirrors the client-v3 implementation: LINE_ORDER_INDEX/ORDERED_CUE_ENTRIES/
LAST_CUE_PER_TYPE_AT Vuex getters, a CurrentCueFooter.vue component reusing
cueDisplayMixin, the same computeContentSize()/ResizeObserver fix in
ScriptViewPane.vue, the same follower currentLineOnPage gap fix, and the
toggle added to the existing User Settings form.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@sonarqubecloud

sonarqubecloud Bot commented Jul 9, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
4.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@github-actions github-actions Bot added client Pull requests changing front end code large-diff and removed medium-diff labels Jul 9, 2026
@Tim020
Tim020 merged commit fd3d2db into dev Jul 9, 2026
34 of 35 checks passed
@Tim020
Tim020 deleted the feature/live-current-cue-footer branch July 9, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

claude Issues created by Claude client Pull requests changing front end code client-v3 documentation Improvements or additions to documentation large-diff server Pull requests changing back end code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant