Repository navigation
Add tall ceiling and floor delimiters to pickTallParts - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Multi-row expressions enclosed in ceiling or floor delimiters (e.g.,
\left\lceil \frac{a}{b} \right\rceilor\left\lfloor \frac{a}{b} \right\rfloor) failed to assemble continuous tall brackets. BecausepickTallParts()only supported(,),[, and], ceiling and floor fell through tounknown-delimiter handling, stamping the literal rune verbatim on every row instead of building top/extension/bottom glyphs.
Fix
"⌈","⌉","⌊", and"⌋"inpickTallParts():BrackLT/BrackRTon top withVBarmiddle and bottom extensions.VBartop and middle extensions withBrackLB/BrackRBon the bottom.TestRegressionCeilFloorDelimitersinregression_test.goverifying tall ceiling, tall floor, single-row delimiters, and ASCII degradation.Verification
go test ./...passed.