Skip to content

Add tall ceiling and floor delimiters to pickTallParts - #1

Merged
doug merged 1 commit into
doug:mainfrom
ashermetzger-rgb:ceil-floor-delimiters
Sep 8, 2026
Merged

doug merged 1 commit into
doug:mainfrom
ashermetzger-rgb:ceil-floor-delimiters

Conversation

@ashermetzger-rgb

Copy link
Copy Markdown
Contributor

Problem

Multi-row expressions enclosed in ceiling or floor delimiters (e.g., \left\lceil \frac{a}{b} \right\rceil or \left\lfloor \frac{a}{b} \right\rfloor) failed to assemble continuous tall brackets. Because pickTallParts() only supported (, ), [, and ], ceiling and floor fell through to
unknown-delimiter handling, stamping the literal rune verbatim on every row instead of building top/extension/bottom glyphs.

Fix

  • Added glyph triple mappings for "⌈", "⌉", "⌊", and "⌋" in pickTallParts():
    • Ceiling: BrackLT / BrackRT on top with VBar middle and bottom extensions.
    • Floor: VBar top and middle extensions with BrackLB / BrackRB on the bottom.
  • Added TestRegressionCeilFloorDelimiters in regression_test.go verifying tall ceiling, tall floor, single-row delimiters, and ASCII degradation.

Verification

  • go test ./... passed.

@doug
doug merged commit eef161d into doug:main Sep 8, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants