Skip to content

[release/10.0.1xx] Restrict CI package publishing to Windows Release #10499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mmitche wants to merge 1 commit into
base: release/10.0.1xx
Choose a base branch
from
+15 −0
Open

[release/10.0.1xx] Restrict CI package publishing to Windows Release #10499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions azure-pipelines-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ stages:
matrix:
Build_Release:
_BuildConfig: Release
_ExtraBuildArgs: ''
# PRs or external builds are not signed.
${{ if or(eq(variables['System.TeamProject'], 'public'), in(variables['Build.Reason'], 'PullRequest')) }}:
_SignType: test
Expand All @@ -90,6 +91,8 @@ stages:
Build_Debug:
_BuildConfig: Debug
_SignType: test
# Only Windows Release publishes to the shared artifact containers.
_ExtraBuildArgs: '/p:Publish=false'

steps:
- checkout: self
Expand All @@ -101,6 +104,7 @@ stages:
-prepareMachine
-integrationTest
$(_InternalBuildArgs)
$(_ExtraBuildArgs)
displayName: Windows Build / Publish

- ${{ if or(eq(variables['System.TeamProject'], 'public'), in(variables['Build.Reason'], 'PullRequest')) }}:
Expand All @@ -120,6 +124,7 @@ stages:
--configuration $(_BuildConfig)
--prepareMachine
--integrationTest
/p:Publish=false
name: Build
displayName: Build

Expand All @@ -144,6 +149,7 @@ stages:
--configuration $(_BuildConfig)
--prepareMachine
--integrationTest
/p:Publish=false
name: Build
displayName: Build
condition: succeeded()
9 changes: 9 additions & 0 deletions azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,11 @@ extends:
os: windows
variables:
- _BuildConfig: ${{ config.buildConfig }}
# Only Windows Release publishes packages to avoid concurrent uploads
# to the shared PackageArtifacts/BlobArtifacts containers.
- _ExtraBuildArgs: ''
- ${{ if ne(config.buildConfig, 'Release') }}:
- _ExtraBuildArgs: '/p:Publish=false'
- _SignType: test
- ${{ if notin(variables['Build.Reason'], 'PullRequest') }}:
- _SignType: real
Expand All @@ -125,13 +130,15 @@ extends:
-prepareMachine
-integrationTest
$(_InternalBuildArgs)
$(_ExtraBuildArgs)
displayName: Windows Build / Publish
- ${{ else }}:
- script: eng/common/cibuild.cmd
-configuration $(_BuildConfig)
-prepareMachine
/p:Test=false
$(_InternalBuildArgs)
$(_ExtraBuildArgs)
displayName: Windows Build / Publish

- ${{ if in(variables['Build.Reason'], 'PullRequest') }}:
Expand All @@ -149,6 +156,7 @@ extends:
--configuration $(_BuildConfig)
--prepareMachine
--integrationTest
/p:Publish=false
name: Build
displayName: Build

Expand All @@ -174,6 +182,7 @@ extends:
--configuration $(_BuildConfig)
--prepareMachine
--integrationTest
/p:Publish=false
name: Build
displayName: Build
condition: succeeded()