Fix outdated Nushell completion script#54743
Open
sibber5 wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the Nushell configuration snippet used for dotnet static completions, simplifying the completer function and adding guidance for combining multiple external completers.
Changes:
- Replaced the previous dictionary-based
external_completerexample with a dedicateddotnet_completer. - Added a
multiple_completersdispatcher and enabled/configured$env.config.completions.external. - Updated inline guidance and linked Nushell documentation for multiple completers.
Author
|
@dotnet-policy-service agree |
baronfel
approved these changes
Jun 12, 2026
baronfel
left a comment
Member
There was a problem hiding this comment.
Thanks for this, and especially the linked docs PR! This will ship in the .NET 11 preview 6 likely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current
dotnet completions script nushelloutput and the official documentation are outdated, use deprecated syntax, and contradict the Dynamic completion scripts section of the documentation (the script stripsdotnetfrom the input while the documentation doesnt).Updated the nushell completions script to follow the official nushell documentation: https://www.nushell.sh/cookbook/external_completers.html
Documentation PR: dotnet/docs#54366