Skip to content

Fix outdated Nushell completion script#54743

Open
sibber5 wants to merge 2 commits into
dotnet:mainfrom
sibber5:patch-1
Open

Fix outdated Nushell completion script#54743
sibber5 wants to merge 2 commits into
dotnet:mainfrom
sibber5:patch-1

Conversation

@sibber5

@sibber5 sibber5 commented Jun 12, 2026

Copy link
Copy Markdown

The current dotnet completions script nushell output and the official documentation are outdated, use deprecated syntax, and contradict the Dynamic completion scripts section of the documentation (the script strips dotnet from the input while the documentation doesnt).

Updated the nushell completions script to follow the official nushell documentation: https://www.nushell.sh/cookbook/external_completers.html

Documentation PR: dotnet/docs#54366

Copilot AI review requested due to automatic review settings June 12, 2026 13:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the Nushell configuration snippet used for dotnet static completions, simplifying the completer function and adding guidance for combining multiple external completers.

Changes:

  • Replaced the previous dictionary-based external_completer example with a dedicated dotnet_completer.
  • Added a multiple_completers dispatcher and enabled/configured $env.config.completions.external.
  • Updated inline guidance and linked Nushell documentation for multiple completers.

@sibber5

sibber5 commented Jun 12, 2026

Copy link
Copy Markdown
Author

@dotnet-policy-service agree

@baronfel baronfel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, and especially the linked docs PR! This will ship in the .NET 11 preview 6 likely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants