Use assembly simple name in ReadyToRun log when path is empty#129837
Open
AndyAyersMS wants to merge 1 commit into
Open
Use assembly simple name in ReadyToRun log when path is empty#129837AndyAyersMS wants to merge 1 commit into
AndyAyersMS wants to merge 1 commit into
Conversation
On hosts like wasm, in-memory/webcil assemblies have no file path, so DOTNET_ReadyToRunLogFile logged an empty name. Fall back to PEAssembly::GetSimpleName() so each entry identifies its module. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
@davidwrighton PTAL |
Contributor
There was a problem hiding this comment.
Pull request overview
This change improves ReadyToRun load logging by ensuring each log entry includes an identifying module name even when an assembly has no filesystem path (e.g., in-memory assemblies).
Changes:
- When
PEAssembly::GetPath()is empty, logPEAssembly::GetSimpleName()instead of an empty string. - Add an explanatory comment describing why the fallback is needed.
pavelsavara
approved these changes
Jun 25, 2026
davidwrighton
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On hosts like wasm, in-memory/webcil assemblies have no file path, so DOTNET_ReadyToRunLogFile logged an empty name. Fall back to PEAssembly::GetSimpleName() so each entry identifies its module.