[browser][coreCLR] workaround Wasm.Build.Tests.IcuTests.FullIcuFromRuntimePackWithInvariant#129243
Open
pavelsavara wants to merge 3 commits into
Open
[browser][coreCLR] workaround Wasm.Build.Tests.IcuTests.FullIcuFromRuntimePackWithInvariant#129243pavelsavara wants to merge 3 commits into
pavelsavara wants to merge 3 commits into
Conversation
pavelsavara
added
arch-wasm
maraf
approved these changes
Jun 10, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the CoreCLR Browser/WASM native link inputs so the runtime pack’s globalization + ICU static archives are always linked, even when InvariantGlobalization=true, to avoid link-time undefined symbols from generated GlobalizationNative_* P/Invoke references.
Changes:
- Removed the
Condition="'$(InvariantGlobalization)' != 'true'"gating fromlibSystem.Globalization.Native.aand ICU archive inputs so they are always included in the CoreCLR WASM link step.
This was referenced Jun 10, 2026
Open
Member
Author
|
Member
Author
|
/ba-g unrelated failures |
| <_CoreCLRNativeLibs Include="$(MicrosoftNetCoreAppRuntimePackRidNativeDir)libicuuc.a" Condition="'$(InvariantGlobalization)' != 'true'" /> | ||
| <_CoreCLRNativeLibs Include="$(MicrosoftNetCoreAppRuntimePackRidNativeDir)libicui18n.a" Condition="'$(InvariantGlobalization)' != 'true'" /> | ||
| <_CoreCLRNativeLibs Include="$(MicrosoftNetCoreAppRuntimePackRidNativeDir)libicudata.a" Condition="'$(InvariantGlobalization)' != 'true'" /> | ||
| <!-- Use Condition="'$(InvariantGlobalization)' != 'true'" after fix for https://github.com/dotnet/runtime/issues/129242 --> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workaround for #129242
Failing probably since #126946