Skip to content

Set ARMEL for TIZEN#129222

Merged
jkotas merged 1 commit into
dotnet:mainfrom
clamp03:fix_tizen_softfp
Jun 11, 2026
Merged

Set ARMEL for TIZEN#129222
jkotas merged 1 commit into
dotnet:mainfrom
clamp03:fix_tizen_softfp

Conversation

@clamp03

@clamp03 clamp03 commented Jun 10, 2026

Copy link
Copy Markdown
Member

Fixes an issue on Tizen targets following changes in #127578.
By correctly identifying the Tizen ARM host and setting CLR_CMAKE_HOST_ARCH to "armel",
this ensures that the required SOFTFP build option is properly applied, resolving the runtime failure.

@clamp03

clamp03 commented Jun 10, 2026

Copy link
Copy Markdown
Member Author

@dotnet/samsung FYI

@clamp03 clamp03 requested review from am11 and simonrozsival June 10, 2026 08:54

@am11 am11 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you.

@am11

am11 commented Jun 10, 2026

Copy link
Copy Markdown
Member

cc @janvorli, @simonrozsival it looks like a typo.

@clamp03

clamp03 commented Jun 11, 2026

Copy link
Copy Markdown
Member Author

#127578 removed some codes which add some SOFTP build options. Because some of them were used for Tizen ARMEL, currently it built without ARM_SOFTP option. To support ARM_SOFTFP, this PR updates CLR_CMAKE_HOST_ARCH value from ARM to ARMEL for TIZEN.

elseif(CLR_CMAKE_TARGET_ARCH STREQUAL armel)
set(CLR_CMAKE_TARGET_ARCH_ARM 1)
set(ARM_SOFTFP 1)

if(ARM_SOFTFP)
add_definitions(-DARM_SOFTFP)
add_compile_options(-mfloat-abi=softfp)
endif(ARM_SOFTFP)

@jkotas

jkotas commented Jun 11, 2026

Copy link
Copy Markdown
Member

/ba-g The job running on agent NetCore-Public 381 ran longer than the maximum time of 180 minutes.

@jkotas jkotas merged commit a3639b1 into dotnet:main Jun 11, 2026
163 of 168 checks passed
BoyBaykiller pushed a commit to BoyBaykiller/runtime that referenced this pull request Jun 11, 2026
Fixes an issue on Tizen targets following changes in dotnet#127578.
By correctly identifying the Tizen ARM host and setting
CLR_CMAKE_HOST_ARCH to "armel",
this ensures that the required SOFTFP build option is properly applied,
resolving the runtime failure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants