Clarify JIT-EE method placement in add-new-jit-ee-api skill#129127
Clarify JIT-EE method placement in add-new-jit-ee-api skill#129127Copilot wants to merge 3 commits into
Conversation
Co-authored-by: jakobbotsch <7887810+jakobbotsch@users.noreply.github.com>
|
I think the code-reviewer just auto-loads the Add-jit-ee skill where it is told to add new APIs at the end, so we probably should fix the skill instead? https://github.com/dotnet/runtime/blob/main/.github/skills/add-new-jit-ee-api/SKILL.md (or do both changes). I told it to append in the end because previously the order did matter for amount of auto-generated changes (there was some big map re-generated completely if you add the new API anywhere but in the end - it was fixed relatively recently). |
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
@copilot do this instead |
…ert instructions change Co-authored-by: jakobbotsch <7887810+jakobbotsch@users.noreply.github.com>
Done in d-latest: reverted the |
|
@copilot no need to mention that the order doesn't matter 7 times, could you please reduce that noise a bit? |
…skill Co-authored-by: EgorBo <523221+EgorBo@users.noreply.github.com>
The
add-new-jit-ee-apiskill instructed the code reviewer to add new JIT-EE (JIT-VM) interface methods at specific positions (e.g. at the end, near similar signatures), even though new JIT-EE methods can now be added anywhere with any ordering without issues.Description
.github/skills/add-new-jit-ee-api/SKILL.mdso its implementation steps no longer mandate a specific position or ordering for new JIT-EE methods. Instead of repeating this note in each step, a singleNOTEwas added at the top of the implementation steps section stating that the position and ordering of new entries/methods does not matter and that any suggested placement (e.g. "at the end" or "near similar signatures") is just a convenient default, not a requirement. The original per-step wording is otherwise preserved.