Skip to content

Clarify JIT-EE method placement in add-new-jit-ee-api skill#129127

Draft
Copilot wants to merge 3 commits into
mainfrom
copilot/amend-jit-instructions
Draft

Clarify JIT-EE method placement in add-new-jit-ee-api skill#129127
Copilot wants to merge 3 commits into
mainfrom
copilot/amend-jit-instructions

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jun 8, 2026

The add-new-jit-ee-api skill instructed the code reviewer to add new JIT-EE (JIT-VM) interface methods at specific positions (e.g. at the end, near similar signatures), even though new JIT-EE methods can now be added anywhere with any ordering without issues.

Description

  • Updated .github/skills/add-new-jit-ee-api/SKILL.md so its implementation steps no longer mandate a specific position or ordering for new JIT-EE methods. Instead of repeating this note in each step, a single NOTE was added at the top of the implementation steps section stating that the position and ordering of new entries/methods does not matter and that any suggested placement (e.g. "at the end" or "near similar signatures") is just a convenient default, not a requirement. The original per-step wording is otherwise preserved.

Co-authored-by: jakobbotsch <7887810+jakobbotsch@users.noreply.github.com>
@EgorBo
Copy link
Copy Markdown
Member

EgorBo commented Jun 8, 2026

I think the code-reviewer just auto-loads the Add-jit-ee skill where it is told to add new APIs at the end, so we probably should fix the skill instead? https://github.com/dotnet/runtime/blob/main/.github/skills/add-new-jit-ee-api/SKILL.md (or do both changes).

I told it to append in the end because previously the order did matter for amount of auto-generated changes (there was some big map re-generated completely if you add the new API anywhere but in the end - it was fixed relatively recently).

@github-actions github-actions Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 8, 2026
@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@jakobbotsch
Copy link
Copy Markdown
Member

I think the code-reviewer just auto-loads the Add-jit-ee skill where it is told to add new APIs at the end, so we probably should fix the skill instead? https://github.com/dotnet/runtime/blob/main/.github/skills/add-new-jit-ee-api/SKILL.md (or do both changes).

I told it to append in the end because previously the order did matter for amount of auto-generated changes (there was some big map re-generated completely if you add the new API anywhere but in the end - it was fixed relatively recently).

@copilot do this instead

…ert instructions change

Co-authored-by: jakobbotsch <7887810+jakobbotsch@users.noreply.github.com>
Copilot AI requested review from Copilot and removed request for Copilot June 8, 2026 13:26
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Jun 8, 2026

I think the code-reviewer just auto-loads the Add-jit-ee skill where it is told to add new APIs at the end, so we probably should fix the skill instead? https://github.com/dotnet/runtime/blob/main/....

Done in d-latest: reverted the jit.instructions.md change and instead updated .github/skills/add-new-jit-ee-api/SKILL.md so the steps no longer mandate a specific position/ordering for new JIT-EE methods (the "add at the end / near similar signatures" wording is now noted as just one acceptable option).

Copilot AI changed the title Clarify JIT-EE method placement in JIT code review instructions Clarify JIT-EE method placement in add-new-jit-ee-api skill Jun 8, 2026
@EgorBo
Copy link
Copy Markdown
Member

EgorBo commented Jun 8, 2026

@copilot no need to mention that the order doesn't matter 7 times, could you please reduce that noise a bit?

…skill

Co-authored-by: EgorBo <523221+EgorBo@users.noreply.github.com>
Copilot AI requested review from Copilot and removed request for Copilot June 8, 2026 13:33
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Jun 8, 2026

@copilot no need to mention that the order doesn't matter 7 times, could you please reduce that noise a bit?

Done in 9c99d01: replaced the 7 per-step mentions with a single NOTE at the top of the implementation steps and restored the original per-step wording.

Copilot finished work on behalf of EgorBo June 8, 2026 13:33
Copilot AI requested a review from EgorBo June 8, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants