[ci-scan] Skip SpanDestinationFunctions_ValueRange on iOS (refs #129045)#129112
Draft
github-actions[bot] wants to merge 2 commits into
Draft
[ci-scan] Skip SpanDestinationFunctions_ValueRange on iOS (refs #129045)#129112github-actions[bot] wants to merge 2 commits into
github-actions[bot] wants to merge 2 commits into
Conversation
The vectorized Tan implementation in TensorPrimitives produces values with reduced precision on iOS simulator ARM64 compared to the scalar reference. This causes SpanDestinationFunctions_ValueRange to fail for both Single and Double precision types. Add [ActiveIssue] targeting TestPlatforms.iOS to suppress the test until the vectorized implementation is fixed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasoning
The vectorized
Tanimplementation inTensorPrimitivesproduces values with reduced precision on iOS simulator ARM64 compared to the scalar reference. When FMA is reported as supported (which it is on ARM64), no tolerance is applied, causingAssert.All()to fail with 123/201 items not matching for Double and 153/201 for Single precision.The chosen
[ActiveIssue]attribute targetingTestPlatforms.iOSis the narrowest available annotation for this platform-specific vectorization issue.Linked KBE: #129045
Match verification (from Step 4.8):
SpanDestinationFunctions_ValueRangeis the exact method named in [ci-scan] Test failure: TensorPrimitives.SpanDestinationFunctions_ValueRange (Tan) on iossimulator #129045Assert.All() Failurewith Tan precision mismatch matches KBE's ErrorMessageImpact on platforms
Errors log
First build it occurred
Linked issue
#129045
Filed by
ci-failure-scan, which scans dnceng-public outer-loop pipelines onmainand converts stable failures into KBEs and test-disable PRs. Comment here or on the workflow file to suggest changes;ci-failure-scan-feedbackreads in-scope feedback daily and opens (or updates) a PR with prompt edits.Note
🔒 Integrity filter blocked 15 items
The following items were blocked because they don't meet the GitHub integrity level.
search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".To allow these resources, lower
min-integrityin your GitHub frontmatter: