Skip to content

Clarify MetadataLoadContext load wording #129050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marko1olo wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

Clarify MetadataLoadContext load wording #129050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libraries/System.Reflection.MetadataLoadContext/src/Resources/Strings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@
<value>The assembly '{0}' has already loaded been loaded into this MetadataLoadContext.</value>
</data>
<data name="FileNotFoundAssembly" xml:space="preserve">
<value>Could not find assembly '{0}'. Either explicitly load this assembly using a method such as LoadFromAssemblyPath() or use a MetadataAssemblyResolver that returns a valid assembly.</value>
<value>Could not find assembly '{0}'. Use a MetadataAssemblyResolver that returns a valid assembly for this assembly name.</value>
</data>
<data name="FileNotFoundModule" xml:space="preserve">
<value>Could not find the module file for '{0}'.</value>
Expand Down
6 changes: 3 additions & 3 deletions ...s/System.Reflection.MetadataLoadContext/src/System/Reflection/MetadataLoadContext.Apis.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ public MetadataLoadContext(MetadataAssemblyResolver resolver, string? coreAssemb
}

/// <summary>
/// Loads an assembly from a specific path on the disk and binds its assembly name to it in the MetadataLoadContext. If a prior
/// Loads an assembly from a specific path on the disk into the MetadataLoadContext. If a prior
/// assembly with the same name was already loaded into the MetadataLoadContext, the prior assembly will be returned. If the
/// two assemblies do not have the same Mvid, this method throws a FileLoadException.
/// </summary>
Expand All @@ -129,7 +129,7 @@ public Assembly LoadFromAssemblyPath(string assemblyPath)
}

/// <summary>
/// Loads an assembly from a byte array and binds its assembly name to it in the MetadataLoadContext. If a prior
/// Loads an assembly from a byte array into the MetadataLoadContext. If a prior
/// assembly with the same name was already loaded into the MetadataLoadContext, the prior assembly will be returned. If the
/// two assemblies do not have the same Mvid, this method throws a FileLoadException.
/// </summary>
Expand All @@ -143,7 +143,7 @@ public Assembly LoadFromByteArray(byte[] assembly)
}

/// <summary>
/// Loads an assembly from a stream and binds its assembly name to it in the MetadataLoadContext. If a prior
/// Loads an assembly from a stream into the MetadataLoadContext. If a prior
/// assembly with the same name was already loaded into the MetadataLoadContext, the prior assembly will be returned. If the
/// two assemblies do not have the same Mvid, this method throws a FileLoadException.
///
Expand Down
Loading