Skip to content

Never attempt to process an RSA 16K key on Android #129033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vcsjones merged 1 commit into from
Jun 5, 2026
+11 −4
Merged

Never attempt to process an RSA 16K key on Android #129033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/EncryptDecrypt.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,7 +644,7 @@ public void RsaDecryptAfterExport()
Assert.Equal(TestData.HelloBytes, output);
}

[Fact]
[ConditionalFact(typeof(ImportExport), nameof(ImportExport.Supports16384))]
public void LargeKeyCryptRoundtrip()
{
byte[] output;
Expand Down
9 changes: 8 additions & 1 deletion ...es/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/ImportExport.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public static void PaddedExport()
RSATestHelpers.AssertKeyEquals(diminishedDPParameters, exported);
}

[Fact]
[ConditionalFact(typeof(ImportExport), nameof(ImportExport.Supports16384))]
public static void LargeKeyImportExport()
{
RSAParameters imported = TestData.RSA16384Params;
Expand Down Expand Up @@ -367,6 +367,13 @@ internal static RSAParameters MakePublic(in RSAParameters rsaParams)

private static bool TestRsa16384()
{
if (PlatformDetection.IsAndroid)
{
// We cannot detect this on Android at the moment. Even attempting to generate or import a 16K RSA key
// may leave the error queue in the incorrect state. See https://github.com/google/conscrypt/issues/1507
return false;
}

try
{
using (RSA rsa = RSAFactory.Create())
Expand Down
4 changes: 2 additions & 2 deletions ...ries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/SignVerify.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1022,7 +1022,7 @@ public void VerifyExpectedSignature_PssSha256_RSA2048()
modulus2048Signature);
}

[Fact]
[ConditionalFact(typeof(ImportExport), nameof(ImportExport.Supports16384))]
public void VerifyExpectedSignature_PssSha256_RSA16384()
{
byte[] modulus2048Signature = (
Expand Down Expand Up @@ -1098,7 +1098,7 @@ public void VerifyExpectedSignature_PssSha256_RSA16384()
modulus2048Signature);
}

[Fact]
[ConditionalFact(typeof(ImportExport), nameof(ImportExport.Supports16384))]
public void VerifyExpectedSignature_PssSha384()
{
byte[] bigModulusSignature = (
Expand Down
Loading