Move remarks back from conceptual docs repo by gewarren · Pull Request #129002 · dotnet/runtime

gewarren · 2026-06-04T17:36:22Z

Contributes to dotnet/dotnet-api-docs#12613.

We're moving supplemental API remarks out of the dotnet/docs repo and back into either:

The /// (like this PR, for libraries that already have their source of truth here)
The dotnet-api-docs repo, in preparation for backporting to ///

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

dotnet-policy-service · 2026-06-04T17:37:47Z

Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions
See info in area-owners.md if you want to be subscribed.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

gewarren · 2026-06-12T00:53:31Z

@jkotas I think I did everything as requested. Are the build failures related to my changes?

jkotas · 2026-06-12T04:44:34Z

Are the build failures related to my changes?

The build failures are unrelated.

Left a few comments. LGTM otherwise.

…o regex-match-remarks

jkotas

Thank you!

jkotas · 2026-06-13T00:36:25Z

/ba-g build analysis is stuck - both failures were mapped to known errors

gewarren added 2 commits June 4, 2026 10:32

move remarks back from conceptual docs repo

a6fbdd5

use full urls

a7a0284

gewarren requested review from Copilot and danmoseley June 4, 2026 17:36

Copilot started reviewing on behalf of gewarren June 4, 2026 17:36 View session

github-actions Bot added the area-System.Text.RegularExpressions label Jun 4, 2026

dotnet-policy-service Bot assigned gewarren Jun 4, 2026

gewarren commented Jun 4, 2026

View reviewed changes

Comment thread src/libraries/System.Text.RegularExpressions/tests/FunctionalTests/Regex.Examples.cs

gewarren requested a review from jkotas June 4, 2026 17:37

Copilot AI reviewed Jun 4, 2026

gewarren requested a review from Copilot June 4, 2026 18:01

Copilot started reviewing on behalf of gewarren June 4, 2026 18:01 View session

Copilot AI reviewed Jun 4, 2026

Copilot stopped reviewing on behalf of gewarren due to an error June 4, 2026 18:35
Copilot had to stop work due to a timeout.

Copilot stopped reviewing on behalf of gewarren due to an error June 4, 2026 19:00
Copilot had to stop work due to a timeout.

gewarren requested a review from Copilot June 4, 2026 21:47

Copilot started reviewing on behalf of gewarren June 4, 2026 21:47 View session

Copilot AI reviewed Jun 4, 2026

View reviewed changes

Apply suggestions from code review

167f5e6

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings June 5, 2026 01:13

Copilot started reviewing on behalf of gewarren June 5, 2026 01:13 View session

Copilot AI reviewed Jun 5, 2026

View reviewed changes

jkotas requested review from AaronRobinsonMSFT and jkotas and removed request for jkotas June 5, 2026 05:39

build-analysis Bot mentioned this pull request Jun 5, 2026

Multiple Helix work items fail on maccatalyst/tvos CoreCLR Release #126460

Open

AaronRobinsonMSFT reviewed Jun 5, 2026

View reviewed changes

Comment thread src/libraries/System.Text.RegularExpressions/src/System/Text/RegularExpressions/Regex.Match.cs

gewarren mentioned this pull request Jun 10, 2026

Reinstate "additional remarks" dotnet/dotnet-api-docs#12613

Open

5 tasks

move file to tests directory

6cf4bc4

Copilot AI review requested due to automatic review settings June 11, 2026 03:18

Copilot started reviewing on behalf of gewarren June 11, 2026 03:18 View session

Copilot AI reviewed Jun 11, 2026

View reviewed changes

gewarren added 2 commits June 10, 2026 20:45

add to test project file

389435e

add asserts

dce5560

Copilot AI review requested due to automatic review settings June 11, 2026 03:51

Copilot started reviewing on behalf of gewarren June 11, 2026 03:51 View session

Copilot AI reviewed Jun 11, 2026

View reviewed changes

Comment thread src/libraries/System.Text.RegularExpressions/src/System/Text/RegularExpressions/Regex.Match.cs Outdated

Potential fix for pull request finding

857d619

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings June 11, 2026 03:59

Copilot started reviewing on behalf of gewarren June 11, 2026 03:59 View session

Copilot AI reviewed Jun 11, 2026

View reviewed changes

Comment thread src/libraries/System.Text.RegularExpressions/src/System/Text/RegularExpressions/Regex.Match.cs Outdated

Comment thread src/libraries/System.Text.RegularExpressions/src/System/Text/RegularExpressions/Regex.Match.cs Outdated

Apply suggestions from code review

39b889f

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings June 11, 2026 04:09

Copilot started reviewing on behalf of gewarren June 11, 2026 04:09 View session

Copilot AI reviewed Jun 11, 2026

View reviewed changes

jkotas reviewed Jun 12, 2026

View reviewed changes

Comment thread ...em.Text.RegularExpressions/tests/FunctionalTests/System.Text.RegularExpressions.Tests.csproj Outdated

gewarren added 2 commits June 12, 2026 08:30

respond to feedback

c6fd816

Merge branch 'regex-match-remarks' of github.com:gewarren/runtime int…

43b0a6d

…o regex-match-remarks

jkotas approved these changes Jun 12, 2026

View reviewed changes

This was referenced Jun 12, 2026

Unable to pull image from mcr.microsoft.com #117164

Open

System.Runtime.Tests.ControlledExecutionTests failing with fatal error #129270

Open

jkotas merged commit f24d574 into dotnet:main Jun 13, 2026
94 of 97 checks passed

dotnet-maestro Bot mentioned this pull request Jun 13, 2026

[main] Source code updates from dotnet/runtime dotnet/dotnet#7196

Open

Conversation

gewarren commented Jun 4, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

dotnet-policy-service Bot commented Jun 4, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

gewarren commented Jun 12, 2026

Uh oh!

Uh oh!

jkotas commented Jun 12, 2026

Uh oh!

jkotas left a comment

Choose a reason for hiding this comment

Uh oh!

jkotas commented Jun 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants