Skip to content

Add use with trusted files remark to FileVersionInfo.GetVersionInfo#128560

Merged
steveisok merged 2 commits into
dotnet:mainfrom
steveisok:add-note-fileversioninfo
Jun 4, 2026
Merged

Add use with trusted files remark to FileVersionInfo.GetVersionInfo#128560
steveisok merged 2 commits into
dotnet:mainfrom
steveisok:add-note-fileversioninfo

Conversation

@steveisok
Copy link
Copy Markdown
Member

No description provided.

@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @steveisok, @dotnet/area-system-diagnostics
See info in area-owners.md if you want to be subscribed.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an XML documentation remark to FileVersionInfo.GetVersionInfo(string) warning callers to use the API only with trusted files, reflecting potential risk from malformed/malicious inputs when extracting version metadata.

Changes:

  • Added a <remarks> section containing a caution <note> to GetVersionInfo.

@jkotas jkotas requested a review from GrabYourPitchforks May 25, 2026 15:35
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 27, 2026 11:11
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

@steveisok
Copy link
Copy Markdown
Member Author

/ba-g Known infra failures

@steveisok steveisok merged commit 5ed7326 into dotnet:main Jun 4, 2026
87 of 93 checks passed
@steveisok steveisok deleted the add-note-fileversioninfo branch June 4, 2026 23:48
@dotnet-milestone-bot dotnet-milestone-bot Bot added this to the 11.0-preview6 milestone Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants