Delete DacDbi APIs AreGCStructuresValid and IsWinRTModule#128014
Open
Delete DacDbi APIs AreGCStructuresValid and IsWinRTModule#128014
Conversation
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Copilot
AI
requested review from
Copilot and
rcj1
and removed request for
Copilot
May 11, 2026 00:22
Contributor
|
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the IDacDbiInterface methods AreGCStructuresValid and IsWinRTModule across CoreCLR native DAC/DBI, the managed cDAC legacy interop mirror, and associated dump-based tests, and simplifies the sole in-tree caller (CordbProcess::EnumerateHeap) accordingly.
Changes:
- Deletes the two methods from the native
IDacDbiInterfacedefinition (IDL + C++ header) and removes their native implementations. - Removes the corresponding managed legacy interop slots and cDAC implementations, plus the related dump tests.
- Simplifies heap enumeration to no longer branch on
AreGCStructuresValid(previously a constant-TRUEimplementation).
Show a summary per file
| File | Description |
|---|---|
| src/coreclr/inc/dacdbi.idl | Removes the two IDacDbiInterface methods from the IDL contract. |
| src/coreclr/debug/inc/dacdbiinterface.h | Removes the pure-virtual declarations and updates WalkHeap documentation to drop references to the removed API. |
| src/coreclr/debug/daccess/dacdbiimpl.h | Drops the two method declarations from DacDbiInterfaceImpl. |
| src/coreclr/debug/daccess/dacdbiimpl.cpp | Deletes the trivial constant-return implementations for the removed methods. |
| src/coreclr/debug/di/process.cpp | Removes AreGCStructuresValid call/branch and always constructs the heap enumerator. |
| src/coreclr/debug/daccess/dacimpl.h | Updates DacHeapWalker docs to remove the AreGCStructuresValid reference. |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.cs | Removes the managed COM interface slots for the deleted methods. |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs | Removes the managed implementations (and DEBUG cross-validation) for the deleted methods. |
| src/native/managed/cdac/tests/DumpTests/DacDbi/DacDbiGCDumpTests.cs | Removes the dump test that cross-validated AreGCStructuresValid. |
| src/native/managed/cdac/tests/DumpTests/DacDbi/DacDbiAppDomainDumpTests.cs | Removes the dump test for IsWinRTModule and the now-unused using. |
Copilot's findings
- Files reviewed: 10/10 changed files
- Comments generated: 1
max-charlamb
approved these changes
May 11, 2026
Open
3 tasks
Contributor
|
@hoyosjs you may need to force merge this, ba-g isn’t working and these have been timing out |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the DacDbi interface methods
AreGCStructuresValidandIsWinRTModuleeverywhere. Both native implementations were trivial constants (TRUEandFALSErespectively), the managed cDAC mirrors did the same, and only one in-tree caller existed.