Add build-monitor-service-hook-deliveries alert to source control#6610
Open
missymessa wants to merge 1 commit into
Open
Add build-monitor-service-hook-deliveries alert to source control#6610missymessa wants to merge 1 commit into
missymessa wants to merge 1 commit into
Conversation
The existing Grafana alert (UID: build-monitor-service-hook-deliveries) was querying for 'ServiceHookNotificationStatus' custom events that no longer exist in the codebase. This caused false-positive alerts via noDataState. Updated the alert to query actual HTTP request telemetry from the DotNetEng-Status App Insights instance for the POST AzurePipelines/BuildComplete endpoint, which is the real webhook handler for AzDO service hook deliveries. Changes: - Query: customEvents/ServiceHookNotificationStatus -> requests/BuildComplete - noDataState: Alerting -> OK - Time bins: \ -> explicit 15m - Data source: dotnet-eng -> DotNetEng-Status-Prod (parameterized) Fixes: https://dev.azure.com/dnceng/internal/_workitems/edit/10629 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the �uild-monitor-service-hook-deliveries Grafana alert rule to source control (Production + Staging).
What changed
The existing Grafana alert was querying for \ServiceHookNotificationStatus\ custom events that no longer exist in the codebase — the telemetry was removed at some point but the alert was never updated. It only fired via
oDataState: Alerting\ (false positive when no data flows), not from actual failure detection.
Updated the alert to:
equests\ table) from DotNetEng-Status App Insights for the \POST AzurePipelines/BuildComplete\ endpoint
oDataState\ from \Alerting\ to \OK\
Production
The alert has already been updated in production Grafana via the API. This PR tracks the change in source control so it's deployed consistently.
Fixes: https://dev.azure.com/dnceng/internal/_workitems/edit/10629