Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With DropOldest, an evicted queued QoS1/2 publish remains in unacknowledged tracking. Even after its replacement is acknowledged, session recovery can enqueue the old publish again. Remove the exact evicted publish object from tracking when it is removed from the data queue. Actual in-flight exchanges remain tracked.
Six regression cases cover QoS0/1/2, with and without an in-flight exchange, replacement acknowledgement and two recoveries. Against unchanged master, four QoS1/2 cases fail as expected and both QoS0 controls pass. With the correction, all 14 selected tests pass on Windows .NET 8, Windows .NET 10 and Linux .NET 10. Identifier allocation and exhaustion behavior are unchanged.