Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Queued packets often have no completion waiter. When a transport write fails, the server catches the error and calls
MqttPacketBusItem.Fail, but the item's faulted completion task can later raiseUnobservedTaskExceptionduring collection.Have the packet-bus item observe its own completion fault after recording it. The task remains faulted: existing and late
WaitAsynccallers still receive the original exception. Public signatures, successful completion, cancellation, and first-completion behavior are unchanged. No global exception suppression is added.The regression includes an unobserved raw-task positive control and verifies that the failed packet task is actually collected. Additional cases verify existing/late waiter exception identity and failure after success/cancellation.
Validation:
18731d9fand the current Enforce per-connection MQTT 5 server send quota #2265 head, while the other packet-bus-item cases pass.git diff --checkpass.This is a standalone fix for a pre-existing ownership gap. It was investigated after the cleanup exceptions in #2265/#2266, but the historical CI logs do not identify their originating packet or test; this PR does not claim those historical triggers have been identified.