Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MQTT 5 SUBSCRIBE decoder accepts Subscription Identifier zero and silently overwrites duplicate identifiers. Reject both as Protocol Errors, as required by MQTT 5.0 section 3.8.2.1.2: https://docs.oasis-open.org/mqtt/mqtt/v5.0/os/mqtt-v5.0-os.html.
Validation is local to each SUBSCRIBE packet. An absent identifier, valid boundary values, repeated User Properties, identifier reuse in separate SUBSCRIBE packets, and repeated identifiers in server-to-client PUBLISH remain accepted. No public API or MQTT 3 decoder changes.
Reproduction on master 18731d9: following a successful MQTT 5 CONNECT, SUBSCRIBE bytes
82 09 00 01 02 0B 00 00 01 61 00receive SUBACK despite identifier zero. The fixed server closes the connection. Four synthetic negative regression cases fail on unmodified master; six positive cases pass.Validation:
git diff --checkand decoder whitespace verification pass.Release solution build also passed with three warnings in unchanged benchmark code.