Fix keep alive detection during publishing - #2259
Open
suhashollakc wants to merge 1 commit into
Open
suhashollakc wants to merge 1 commit into
suhashollakc wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2244
Summary
This fixes keep-alive detection when a client continuously publishes QoS 0 messages over a half-open connection.
The keep-alive loop previously considered only the last packet sent. Periodic publishes kept refreshing that timestamp even when the broker returned no traffic, so the client never sent a PINGREQ and
DisconnectedAsynccould remain silent indefinitely.Changes
Validation
dotnet test --project Source\MQTTnet.Tests\MQTTnet.Tests.csproj --framework net10.0 --no-restore --filter "KeepAlive_Timeout_Raises_Disconnected_While_Publishing|KeepAlive_Ping_Send_Timeout_Raises_Disconnected|Publish_QoS_0_Over_Period_Exceeding_KeepAlive"dotnet test --project Source\MQTTnet.Tests\MQTTnet.Tests.csproj --framework net10.0 --no-restore --filter FullyQualifiedName~MQTTnet.Tests.Clients.MqttClient.MqttClient_Testsdotnet build MQTTnet.slnx --no-restoreThe solution build succeeds with the existing ASP.NET benchmark deprecation warnings.