Add attendee plates#3130
Draft
brage-andreas wants to merge 2 commits into
Draft
Conversation
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
a51fb8b to
b7b7b8d
Compare
dd6a738 to
2f9c807
Compare
b7b7b8d to
5109dcd
Compare
2f9c807 to
25e92dc
Compare
25e92dc to
98f3554
Compare
5109dcd to
7e26c61
Compare
7e26c61 to
0d641ba
Compare
98f3554 to
ad2524e
Compare
0d641ba to
a20cad5
Compare
ad2524e to
fcdcb07
Compare
d1bcdb9 to
e371f68
Compare
8b99d17 to
3cfbcf7
Compare
05629b6 to
43420c7
Compare
43420c7 to
9eb10ed
Compare
3cfbcf7 to
4ca7774
Compare
dfd4ce1 to
2943375
Compare
2943375 to
e0fcc43
Compare
1d5e85b to
7b4a608
Compare
5b9cb4d to
5b4c3ad
Compare
0183094 to
9967eb7
Compare
150d452 to
d6ab826
Compare
a3f0b6d to
2e868e0
Compare
d6ab826 to
1676261
Compare
2e868e0 to
750c53c
Compare
1676261 to
4910b0a
Compare
750c53c to
510fdb9
Compare
1ee1fba to
537e5e6
Compare
177ec4e to
b65715d
Compare
537e5e6 to
c5f4db3
Compare
b65715d to
dbb84f0
Compare
9534f53 to
e0a6a39
Compare
3ffa09a to
f4ab617
Compare
9ee7c14 to
f851e77
Compare
af0f601 to
9daea53
Compare
9daea53 to
ae50086
Compare
0705dd4 to
4ec7e5b
Compare
ae50086 to
05ede9d
Compare
Comment on lines
+8
to
+9
| export function GenericPlate({ attendee, user, userSection: customUserSection, rightSection }: PlateProps) { | ||
| const { largeIcon, smallIcons } = getAttendeeIcons(attendee) |
There was a problem hiding this comment.
Props smallIcons and largeIcon from PlateProps are not being destructured, causing them to be ignored. The component then re-computes these values instead of using the passed props. This is inconsistent with VanityVerifiedPlate which correctly uses the passed props.
export function GenericPlate({ attendee, user, smallIcons, largeIcon, userSection: customUserSection, rightSection }: PlateProps) {
// Remove line 9: const { largeIcon, smallIcons } = getAttendeeIcons(attendee)The props are already computed in AttendeeList.tsx at line 19 and should be reused rather than recalculated.
Suggested change
| export function GenericPlate({ attendee, user, userSection: customUserSection, rightSection }: PlateProps) { | |
| const { largeIcon, smallIcons } = getAttendeeIcons(attendee) | |
| export function GenericPlate({ attendee, user, smallIcons, largeIcon, userSection: customUserSection, rightSection }: PlateProps) { | |
Spotted by Graphite
Is this helpful? React 👍 or 👎 to let us know.
05ede9d to
ae1d0ce
Compare
4ec7e5b to
6eb1a5a
Compare
ae1d0ce to
bf7a587
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.