Skip to content

Add attendee plates#3130

Draft
brage-andreas wants to merge 2 commits into
graphite-base/3130from
add-attendee-plates
Draft

Add attendee plates#3130
brage-andreas wants to merge 2 commits into
graphite-base/3130from
add-attendee-plates

Conversation

@brage-andreas

Copy link
Copy Markdown
Member

No description provided.

brage-andreas commented Apr 25, 2026

Copy link
Copy Markdown
Member Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@brage-andreas brage-andreas changed the title feat: move user flags to table Add attendee plates Apr 25, 2026
@brage-andreas brage-andreas force-pushed the move-user-flags-to-table branch from dd6a738 to 2f9c807 Compare April 25, 2026 14:02
@brage-andreas brage-andreas force-pushed the move-user-flags-to-table branch from 2f9c807 to 25e92dc Compare April 25, 2026 15:22
@brage-andreas brage-andreas changed the base branch from move-user-flags-to-table to graphite-base/3130 April 27, 2026 16:25
@brage-andreas brage-andreas changed the base branch from graphite-base/3130 to move-user-flags-to-table April 30, 2026 19:54
@brage-andreas brage-andreas force-pushed the move-user-flags-to-table branch from 98f3554 to ad2524e Compare May 1, 2026 13:08
@brage-andreas brage-andreas force-pushed the add-attendee-plates branch from 0d641ba to a20cad5 Compare May 1, 2026 13:08
@brage-andreas brage-andreas force-pushed the move-user-flags-to-table branch from ad2524e to fcdcb07 Compare May 1, 2026 19:28
@brage-andreas brage-andreas force-pushed the add-attendee-plates branch 2 times, most recently from d1bcdb9 to e371f68 Compare May 1, 2026 23:01
@brage-andreas brage-andreas force-pushed the move-user-flags-to-table branch from 8b99d17 to 3cfbcf7 Compare May 2, 2026 16:58
@brage-andreas brage-andreas force-pushed the add-attendee-plates branch 2 times, most recently from 05629b6 to 43420c7 Compare May 3, 2026 17:03
@brage-andreas brage-andreas force-pushed the add-attendee-plates branch from 43420c7 to 9eb10ed Compare May 3, 2026 17:04
@brage-andreas brage-andreas force-pushed the move-user-flags-to-table branch from 3cfbcf7 to 4ca7774 Compare May 3, 2026 17:10
@brage-andreas brage-andreas force-pushed the add-attendee-plates branch 3 times, most recently from dfd4ce1 to 2943375 Compare May 3, 2026 22:41
@brage-andreas brage-andreas force-pushed the add-attendee-plates branch from 2943375 to e0fcc43 Compare May 3, 2026 22:41
@brage-andreas brage-andreas force-pushed the move-user-flags-to-table branch from 1d5e85b to 7b4a608 Compare May 8, 2026 12:26
@brage-andreas brage-andreas force-pushed the add-attendee-plates branch from 5b9cb4d to 5b4c3ad Compare May 8, 2026 12:26
@brage-andreas brage-andreas force-pushed the add-attendee-plates branch from 0183094 to 9967eb7 Compare May 13, 2026 23:02
@brage-andreas brage-andreas force-pushed the move-user-flags-to-table branch from 150d452 to d6ab826 Compare May 13, 2026 23:44
@brage-andreas brage-andreas force-pushed the add-attendee-plates branch 2 times, most recently from a3f0b6d to 2e868e0 Compare May 14, 2026 14:34
@brage-andreas brage-andreas force-pushed the move-user-flags-to-table branch from d6ab826 to 1676261 Compare May 14, 2026 14:34
@brage-andreas brage-andreas force-pushed the add-attendee-plates branch from 2e868e0 to 750c53c Compare May 14, 2026 17:24
@brage-andreas brage-andreas force-pushed the move-user-flags-to-table branch from 1676261 to 4910b0a Compare May 14, 2026 17:24
@brage-andreas brage-andreas force-pushed the add-attendee-plates branch from 750c53c to 510fdb9 Compare May 19, 2026 10:45
@brage-andreas brage-andreas force-pushed the move-user-flags-to-table branch from 1ee1fba to 537e5e6 Compare May 19, 2026 21:58
@brage-andreas brage-andreas force-pushed the add-attendee-plates branch 2 times, most recently from 177ec4e to b65715d Compare May 19, 2026 23:17
@brage-andreas brage-andreas force-pushed the move-user-flags-to-table branch from 537e5e6 to c5f4db3 Compare May 19, 2026 23:17
@brage-andreas brage-andreas force-pushed the add-attendee-plates branch from b65715d to dbb84f0 Compare May 19, 2026 23:32
@brage-andreas brage-andreas force-pushed the move-user-flags-to-table branch 2 times, most recently from 9534f53 to e0a6a39 Compare May 21, 2026 17:19
@brage-andreas brage-andreas force-pushed the add-attendee-plates branch 2 times, most recently from 3ffa09a to f4ab617 Compare May 23, 2026 16:02
@brage-andreas brage-andreas force-pushed the move-user-flags-to-table branch from 9ee7c14 to f851e77 Compare May 25, 2026 16:56
@brage-andreas brage-andreas force-pushed the add-attendee-plates branch 2 times, most recently from af0f601 to 9daea53 Compare May 25, 2026 22:03
@brage-andreas brage-andreas force-pushed the move-user-flags-to-table branch from 0705dd4 to 4ec7e5b Compare June 14, 2026 12:11
Comment on lines +8 to +9
export function GenericPlate({ attendee, user, userSection: customUserSection, rightSection }: PlateProps) {
const { largeIcon, smallIcons } = getAttendeeIcons(attendee)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Props smallIcons and largeIcon from PlateProps are not being destructured, causing them to be ignored. The component then re-computes these values instead of using the passed props. This is inconsistent with VanityVerifiedPlate which correctly uses the passed props.

export function GenericPlate({ attendee, user, smallIcons, largeIcon, userSection: customUserSection, rightSection }: PlateProps) {
  // Remove line 9: const { largeIcon, smallIcons } = getAttendeeIcons(attendee)

The props are already computed in AttendeeList.tsx at line 19 and should be reused rather than recalculated.

Suggested change
export function GenericPlate({ attendee, user, userSection: customUserSection, rightSection }: PlateProps) {
const { largeIcon, smallIcons } = getAttendeeIcons(attendee)
export function GenericPlate({ attendee, user, smallIcons, largeIcon, userSection: customUserSection, rightSection }: PlateProps) {

Spotted by Graphite

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

@brage-andreas brage-andreas force-pushed the move-user-flags-to-table branch from 4ec7e5b to 6eb1a5a Compare June 17, 2026 15:48
@brage-andreas brage-andreas changed the base branch from move-user-flags-to-table to graphite-base/3130 June 26, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant