Skip to content

Chore: Enable New Block Editor by Default#36257

Open
rjvelazco wants to merge 3 commits into
mainfrom
issue-36254-enable-block-editor-20-by-default
Open

Chore: Enable New Block Editor by Default#36257
rjvelazco wants to merge 3 commits into
mainfrom
issue-36254-enable-block-editor-20-by-default

Conversation

@rjvelazco

@rjvelazco rjvelazco commented Jun 22, 2026

Copy link
Copy Markdown
Member

Turn of the New Block Editor by default

This PR fixes: #36254

Remove feature flag for the new TipTap-v3 block editor.
@rjvelazco rjvelazco linked an issue Jun 22, 2026 that may be closed by this pull request
5 tasks
@github-actions github-actions Bot added the Area : Backend PR changes Java/Maven backend code label Jun 22, 2026
@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

🤖 Bedrock Review — deepseek.v3.2

[🟡 Medium] dotCMS/src/main/resources/dotmarketing-config.properties:867 — Removed feature flag FEATURE_FLAG_NEW_BLOCK_EDITOR without a clear migration or fallback plan. This could break existing functionality if the flag was actively used to toggle between old and new editors, leaving no way to revert.


Run: #27964517364 · tokens: in: 544 · out: 74 · total: 618

@claude

claude Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Claude finished @rjvelazco's task in 49s —— View job


Rollback Safety Analysis

  • Read rollback-unsafe categories reference
  • Get full PR diff
  • Analyze changes against unsafe categories
  • Apply appropriate label

Analysis

The PR contains two changed files:

1. dotCMS/src/main/resources/dotmarketing-config.properties

  • Removes FEATURE_FLAG_NEW_BLOCK_EDITOR=false and replaces it with FEATURE_FLAG_LOCALE_SELECTOR_V2=true
  • This is a pure configuration/feature flag change. No database migrations, no Elasticsearch mapping changes, no data model modifications.

2. dotCMS/src/main/webapp/html/portlet/ext/contentlet/edit_contentlet.jsp

  • Adds ReleaseInfo.getBuildNumber() to cache-bust block editor static asset URLs (appends ?v=<buildNumber> to CSS/JS script tags)
  • This is a pure UI/template change with no data persistence implications.

Verdict: ✅ Safe To Rollback

None of the changes match any unsafe rollback category:

  • No runonce database migration tasks
  • No Elasticsearch mapping changes
  • No content model version bumps
  • No DROP/RENAME table or column operations
  • No REST/GraphQL API contract changes
  • No VTL viewtool contract changes
  • No binary storage provider changes
  • No OSGi interface modifications

The feature flag removal (FEATURE_FLAG_NEW_BLOCK_EDITOR) and addition (FEATURE_FLAG_LOCALE_SELECTOR_V2) are purely configuration-layer changes. Rolling back to N-1 would simply restore the previous flag values with no data loss or breakage. The cache-busting change in the JSP is equally safe — rolling back reverts to un-versioned asset URLs with no functional impact.

Label added: AI: Safe To Rollback

@rjvelazco rjvelazco marked this pull request as ready for review June 22, 2026 18:38
rjvelazco and others added 2 commits June 25, 2026 09:09
The JSP loaded /dotcms-block-editor/{polyfills,generator-runtime,main}.js and
styles.css at fixed URLs, and the web-component app builds with outputHashing:none,
so after a dotCMS upgrade browsers kept serving the stale editor bundle from cache
until a manual hard-reload — the symptom where the new Block Editor "wouldn't load"
until a full reload. Append ?v=<build revision> (ReleaseInfo.getBuildNumber()) so the
URL changes per build and the cache busts automatically.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

🤖 Bedrock Review — qwen.qwen3-next-80b-a3b

New Issues

  • 🟠 High: dotCMS/src/main/webapp/html/portlet/ext/contentlet/edit_contentlet.jsp:82ReleaseInfo.getBuildNumber() returns a String that is directly concatenated into HTML attributes without escaping. If the build number contains unescaped characters (e.g., &, <, ", '), it can break HTML or enable XSS. Must use org.apache.commons.lang3.StringEscapeUtils.escapeHtml4() or equivalent.

Existing

  • 🟡 Medium: dotCMS/src/main/webapp/html/portlet/ext/contentlet/edit_contentlet.jsp:76Logger is imported but not used; System.out or unlogged errors may be used elsewhere in this file (not changed by PR, but pre-existing).

Resolved

  • dotCMS/src/main/webapp/html/portlet/ext/contentlet/edit_contentlet.jsp:79-82 — Legacy asset loading removed; replaced with versioned URLs (improves cache behavior, though XSS risk remains).

Run: #28187498032 · tokens: in: 1702 · out: 274 · total: 1976

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI: Safe To Rollback Area : Backend PR changes Java/Maven backend code

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Enable Block Editor 2.0 by default

1 participant