feat: add task room create and launch flow#1052
Conversation
|
Warning Review limit reached
More reviews will be available in 29 minutes and 24 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (13)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request introduces a new task room creation panel in the topic sidebar, allowing users to create workspace topic rooms and optionally launch agent sessions. It adds the corresponding API endpoints, action registry integrations, and comprehensive unit tests. The review feedback highlights a bug in the task reference regular expression that causes false-positive GitHub issue classifications, and identifies redundant workContext construction in TopicSidebarShell that is already handled by the API helper.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| const issueMatch = trimmed.match(/(?:issues\/|#)?(\d+)\b/); | ||
| if (!issueMatch) { | ||
| return { kind: 'external', id: trimmed, title }; | ||
| } | ||
| const issueId = issueMatch[1]!; |
There was a problem hiding this comment.
The current regular expression /(?:issues\/|#)?(\d+)\b/ has an optional prefix, which causes it to match any number in the input string (e.g., 'Fix bug in v2' matches '2', and 'JIRA-123' matches '123'). This leads to false-positive GitHub issue classifications. Consider restricting the match to pure numbers, numbers prefixed with #, or explicit issues/<id> paths.
const issueMatch = trimmed.match(/^(?:#)?(\\d+)$/) || trimmed.match(/\\bissues\\/(\\d+)/);
if (!issueMatch) {
return { kind: 'external', id: trimmed, title };
}
const issueId = issueMatch[1]!;
| workContext: { | ||
| title: previewCreate.title, | ||
| anchors: { | ||
| project: { workspaceId: previewCreate.workspaceId }, | ||
| repo: { | ||
| ...(previewCreate.routingDefaults?.repoPath | ||
| ? { localPath: previewCreate.routingDefaults.repoPath } | ||
| : {}), | ||
| }, | ||
| worktree: { | ||
| ...(previewCreate.routingDefaults?.worktreePath | ||
| ? { localPath: previewCreate.routingDefaults.worktreePath } | ||
| : {}), | ||
| }, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
The workContext object construction here is fully redundant. The createWorkContextForTopicRoom helper in api.ts already automatically defaults the title to input.topic.title and constructs the exact same anchors (project, repo, and worktree) from the topic's routing defaults if workContext is omitted. Removing this block simplifies the code and avoids duplicating the anchor resolution logic.
|
Verdict: changes requested. Review exact head: 8af42e1 Blockers:
Non-blocking concern:
Bot triage:
Evidence checked:
Unblock by fixing both blockers on the same PR branch and rerunning targeted tests/check/build. Fresh exact-head QA/review needed after the new head, obviously. (-_-;) |
|
Verdict: approve. Review exact head: b27508d Blockers: none. Why this unblocks the prior review:
Coverage ledger:
Evidence:
Bot feedback + learning:
|
Summary
Closes #1045
Verification
Simplify