Skip to content

Remove the Concepts page - #10

Merged
donbr merged 1 commit into
mainfrom
chore/remove-concepts-page
Oct 2, 2026
Merged

donbr merged 1 commit into
mainfrom
chore/remove-concepts-page

Conversation

@donbr

@donbr donbr commented Oct 2, 2026

Copy link
Copy Markdown
Owner

Summary

Removes /concepts. The page was generated in b03de6c (5 Nov 2025, a Claude Code session committed directly to main) and opened with a first-person anecdote — "A student once asked me: 'Should I refactor my FastAPI RAG system to use FastMCP?'" — that never happened. No earlier source for the page or the anecdote exists anywhere in the repo's history.

  • Deletes src/pages/ConceptsPage.tsx
  • Removes its route from src/App.tsx and the Concepts link from Layout.tsx
  • Drops "Concepts" from the nav list in CLAUDE.md

/concepts now renders the app's 404 page. (Until the 404.html SPA fallback in #9 ships, a direct request on GitHub Pages gets GitHub's own 404 instead; either way the content is gone.) The page text remains recoverable from git history.

This is the first PR in a stack: this → #9 (fixes and performance) → follow-ups. It's independent and small so it can merge and deploy first.

Test plan

  • npm run build passes; npx tsc -p tsconfig.app.json --noEmit passes; npm run lint 0 errors (3 pre-existing warnings)
  • No remaining references to the page in src, public or CLAUDE.md
  • vite preview: /concepts renders "404 - Page Not Found"; nav shows About, Expertise, Publications, Projects, Teaching, Certifications, Contact, Graph Demos
  • After merge + npm run deploy: https://donbr.github.io/concepts no longer shows the page

🤖 Generated with Claude Code

https://claude.ai/code/session_01Ppa5DyJCZ1CowKtz58QARN

The page was generated in b03de6c (Nov 2025) and opened with an anecdote
that never happened. Removes ConceptsPage.tsx, its route, the Concepts nav
link and the CLAUDE.md nav mention. /concepts now falls through to the 404
page.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ppa5DyJCZ1CowKtz58QARN
@claude

claude Bot commented Oct 2, 2026

Copy link
Copy Markdown

Review

Clean, minimal removal. I checked the diff and grepped src, public and CLAUDE.md. The only remaining match for "concepts" is unrelated prose in HomePage.tsx.

Code quality

  • The page, route, import and nav link are all removed together. No dead imports or leftovers.
  • The CLAUDE.md nav list is updated. The Routing section never listed /concepts, so nothing else needs changing there.
  • isActive and cn are still used by the other nav links, so no lint fallout.

Bugs / behavior

Performance / security

  • Nothing to flag. The bundle gets smaller, and removing the static page adds no new surface.

Tests

  • The repo has no test framework, and the manual verification in the test plan (build, tsc, lint, preview) is appropriate for this change.
  • The last checkbox, confirming the deployed URL after merge, is the one still open.

Note on the rationale

  • Removing a page with a fabricated first-person anecdote is sensible. The links to langsmith-mcp-server and adv-rag went with it. If the MCP architecture content is worth keeping, a rewritten version without the invented story could come back later.

LGTM.

🤖 Generated with Claude Code

@donbr
donbr merged commit dd281b8 into main Oct 2, 2026
1 check passed
@donbr
donbr deleted the chore/remove-concepts-page branch October 3, 2026 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant