More verbose nxdomain message#256
Merged
seanthegeek merged 1 commit intoJun 8, 2026
Merged
Conversation
kazet
force-pushed
the
more-verbose-nxdomain-message
branch
3 times, most recently
from
5f1ef86 to
2bf6978
Compare
kazet
force-pushed
the
more-verbose-nxdomain-message
branch
from
2bf6978 to
fed828d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #256 +/- ##
=======================================
Coverage 95.43% 95.43%
=======================================
Files 12 12
Lines 2911 2911
=======================================
Hits 2778 2778
Misses 133 133 ☔ View full report in Codecov by Harness. |
Contributor
|
Thanks! |
seanthegeek
added a commit
that referenced
this pull request
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's assume we are processing an SPF record:
v=spf1 mx -allfor domainexample.comhaving a single MX record ofmail.example.comwhich doesn't exist.Previously the error message was
example.com: the domain does not exist.which is false. After this change, the message would beError when processing example.com: the domain mail.example.com does not exist..