build(deps-dev): bump typescript from 5.9.3 to 6.0.3#3443
build(deps-dev): bump typescript from 5.9.3 to 6.0.3#3443dependabot[bot] wants to merge 1 commit into
Conversation
dependabot
Bot
added
dependencies
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe ChangesTypeScript Dependency Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
package.json (1)
102-102: Note: Version mismatch with@microsoft/api-extractor.The
@microsoft/api-extractortool (if used) bundles TypeScript 5.8.2, while the project now uses TypeScript 6.0.3. This could lead to inconsistent type checking results between the main build and API extraction.If API Extractor is actively used in this project, monitor for any discrepancies in type checking behavior between tools. Consider checking if a newer version of
@microsoft/api-extractorsupports TypeScript 6.0.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@package.json` at line 102, package.json declares "typescript": "6.0.3" which may mismatch the TypeScript bundled by `@microsoft/api-extractor` (5.8.2); to fix, either upgrade `@microsoft/api-extractor` to a release that supports TS 6.x or align the project TypeScript to the extractor's supported version, and add a CI check that runs API Extractor to surface any type-checking discrepancies; reference the package name `@microsoft/api-extractor` and the package.json entry "typescript": "6.0.3" when making the change.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@package.json`:
- Line 102: package.json declares "typescript": "6.0.3" which may mismatch the
TypeScript bundled by `@microsoft/api-extractor` (5.8.2); to fix, either upgrade
`@microsoft/api-extractor` to a release that supports TS 6.x or align the project
TypeScript to the extractor's supported version, and add a CI check that runs
API Extractor to surface any type-checking discrepancies; reference the package
name `@microsoft/api-extractor` and the package.json entry "typescript": "6.0.3"
when making the change.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 62d8686e-b406-42ca-ae06-c236a871b4a8
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3443 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 311 311
Lines 3237 3237
Branches 732 732
=========================================
Hits 3237 3237 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/typescript-6.0.3
branch
from
87f7ef8 to
bd55bf4
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@package.json`:
- Line 102: Update package.json's engines.node to align with the resolved
TypeScript runtime requirement: change the "engines.node" field to at least
">=14.17" (or a compatible minimum) so it matches the resolved dependency
typescript@6.0.3 in package-lock.json; locate the "engines" section in
package.json and bump the node semver there, or alternatively downgrade/lock
TypeScript to a version compatible with the current engines.node, ensuring
package-lock.json and package.json agree.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 81951a3c-f7cb-48c3-b704-5204df645df6
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json
| "tsx": "^4.7.0", | ||
| "typedoc": "^0.28.2", | ||
| "typescript": "5.9.3", | ||
| "typescript": "6.0.3", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify engine-floor mismatch between package.json and resolved TypeScript metadata.
set -euo pipefail
echo "package.json engines.node:"
jq -r '.engines.node' package.json
echo
echo "Resolved TypeScript version + engine requirement from package-lock.json:"
jq -r '.packages["node_modules/typescript"] | {version, node_engine: .engines.node}' package-lock.json
echo
echo "Resolved typescript-eslint peer range for TypeScript (compat check):"
jq -r '.packages["node_modules/typescript-eslint"].peerDependencies.typescript' package-lock.jsonRepository: dolanmiu/docx
Length of output: 301
Update engines.node to match the upgraded TypeScript toolchain
package.json sets engines.node: ">=10", but the resolved typescript@6.0.3 in package-lock.json requires engines.node: ">=14.17". This mismatch can break installs/builds for contributors on Node 10–14 and creates a misleading support contract—bump engines.node (e.g., to >=14.17) or adjust the TypeScript version.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@package.json` at line 102, Update package.json's engines.node to align with
the resolved TypeScript runtime requirement: change the "engines.node" field to
at least ">=14.17" (or a compatible minimum) so it matches the resolved
dependency typescript@6.0.3 in package-lock.json; locate the "engines" section
in package.json and bump the node semver there, or alternatively downgrade/lock
TypeScript to a version compatible with the current engines.node, ensuring
package-lock.json and package.json agree.
bd55bf4 to
e0c6739
Compare
Bumps [typescript](https://github.com/microsoft/TypeScript) from 5.9.3 to 6.0.3. - [Release notes](https://github.com/microsoft/TypeScript/releases) - [Commits](microsoft/TypeScript@v5.9.3...v6.0.3) --- updated-dependencies: - dependency-name: typescript dependency-version: 6.0.3 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/typescript-6.0.3
branch
from
e0c6739 to
59fefc0
Compare
Bumps typescript from 5.9.3 to 6.0.3.
Release notes
Sourced from typescript's releases.
Commits
050880cBump version to 6.0.3 and LKGeeae9dd🤖 Pick PR #63401 (Also check package name validity in...) into release-6.0 (#...ad1c695🤖 Pick PR #63368 (Harden ATA package name filtering) into release-6.0 (#63372)0725fb4🤖 Pick PR #63310 (Mark class property initializers as...) into release-6.0 (#...607a22aBump version to 6.0.2 and LKG9e72ab7🤖 Pick PR #63239 (Fix missing lib files in reused pro...) into release-6.0 (#...35ff23d🤖 Pick PR #63163 (Port anyFunctionType subtype fix an...) into release-6.0 (#...e175b69Bump version to 6.0.1-rc and LKGaf4caacUpdate LKG8efd7e8Merge remote-tracking branch 'origin/main' into release-6.0Summary by CodeRabbit