Support direct database URL for startup migrations#691
Draft
maxpetrusenkoagent wants to merge 1 commit into
Draft
Support direct database URL for startup migrations#691maxpetrusenkoagent wants to merge 1 commit into
maxpetrusenkoagent wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MIGRATION_DATABASE_URLsupport for production startup migrationsDATABASE_URLfor normal application traffic, then temporarily switch to the direct migration URL only whileDatabaseTasks.migraterunsFixes #469
Why
Neon documents pooled connections as appropriate for web application traffic, but schema migrations should use direct connections because migration tools may not support transaction pooling. DocuSeal currently runs production startup migrations through the same
DATABASE_URLused by the app, which makes Neon users likely to point Rails migrations at the pooled-poolerURL.Verification
ruby -Ilib -c lib/migration_database_url.rbruby -c config/initializers/migrate.rbruby -c spec/lib/migration_database_url_spec.rbruby /tmp/migration_database_url_harness.rbgit diff --cached --checkLocal test caveat
Full
bundle exec rspec spec/lib/migration_database_url_spec.rbandbundle exec rubocop ...could not run on this Mac because the local system Ruby is 2.6.10, while this repo requires Ruby 4.0.5 and Bundler 4.0.3. The new spec is included so CI can run it with the repo's configured Ruby version.