Skip to content

Removed bower from required dependencies#67

Open
jaboy1409 wants to merge 3 commits into
dnauck:masterfrom
jaboy1409:master
Open

Removed bower from required dependencies#67
jaboy1409 wants to merge 3 commits into
dnauck:masterfrom
jaboy1409:master

Conversation

@jaboy1409

Copy link
Copy Markdown

Saves needing to install bower to use this as a dependency.

npm install is now all you need to run.

@cmalard

cmalard commented Dec 8, 2016

Copy link
Copy Markdown

Fix #66

Thanks for the PR jaboy1409 :-)

  • you can remove bower.json
  • maybe update the README to mention NPM install
  • why updating grunt-contrib-jshint ? (it seems not related to bower removal)

👍

@cmalard

cmalard commented Jan 9, 2017

Copy link
Copy Markdown

@jaboy1409 as this is a PR, you should change

+Download package(until merged into master)
 ```sh
-bower install angular-advanced-searchbox
+npm install

by

 ```sh
-bower install angular-advanced-searchbox
+npm install angular-advanced-searchbox --save

@dnauck dnauck added the wontfix label Nov 9, 2017
@dnauck

dnauck commented Nov 9, 2017

Copy link
Copy Markdown
Owner

Hi @jaboy1409 ,

thanks for your pull request. But removing bower is not an option as this library is still deployed to bower.

@dnauck dnauck self-assigned this Nov 9, 2017
@cmalard

cmalard commented Nov 9, 2017

Copy link
Copy Markdown

Hi @dnauck , Bower is deprecated, so why not ?

-> Migration Path

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants