Validate Agent plans before execution#174
Merged
Merged
Conversation
dmarro89
marked this pull request as ready for review
May 23, 2026 07:29
Owner
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4c5ea2d29f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds stricter Agent plan validation before execution. The validator now rejects actions outside the v0.5.0 plan allowlist, missing required targets, unexpected data payloads, and incorrect risk markings.
Why
Closes #157
LLM-backed plans are untrusted input, so invalid or unsafe plan shapes must be rejected before any executor handler can run.
How to test
gofmt -l .go vet -tags testing -unsafeptr=false ./...go test -tags testing ./...python3 -m py_compile scripts/test_boot.pymake testNote:
make iso && python3 scripts/test_boot.py --functionalis currently blocked in this local environment becausex86_64-elf-gccgois not installed.Pre-flight
gofmt -l .prints nothinggo vet -tags testing -unsafeptr=false ./...is cleanmake testpassespython3 scripts/test_boot.pypasses