fix #23885 - Parallel GC has intermittent long collection pauses … - #23912
Merged
Merged
Conversation
… under single-CPU affinity on Windows and WSL2 don't set the evStackFilled condition if the stack is empty in case very few roots are found: In that case other threads spin without getting any scan range because the condition and the scanStack are out of sync.
thewilsonator
approved these changes
Sep 23, 2026
DMD perf check
All measurements
23c062d vs merge-base ace0c09 · about these metrics |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…under single-CPU affinity on Windows and WSL2
don't set the evStackFilled condition if the stack is empty in case very few roots are found: In that case other threads spin without getting any scan range because the condition and the scanStack are out of sync.
Detected by looking at xperf traces. No idea how to setup a reliable test case.