Conversation
With -lib every function was written to its own archive member, so it could not reach the static variables and functions of its C file and the library failed to link with undefined references. A C file is one translation unit, so it is no longer split. Related to dlang#20152. The library built from compilable/fix22153.c did not link either. The new test builds a library and links it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20152.
A library built with
dmd -libfrom a C file did not link. Each function was written into its own archive member (themultiobjsplit), so it could not reach thestaticvariables and functions of its own C file, and linking against the library failed withundefined reference.A C file is one translation unit, so it is no longer split for
-lib. This also affects #22153's own regression test: the library it builds did not link either, on Linux or Windows, since that test only checked that the library compiled.Test:
dshell/issue20152.d, builds the library and links a consumer against it.Part of SAOC 2026, ImportC: Zero-Wrapper Integration for Production-Grade C Libraries.