Skip to content

dtoh: do not write exact compiler version in silent mode - #11680

Merged
dlang-bot merged 1 commit into
dlang:masterfrom
wilzbach:silent-version
Sep 3, 2020
Merged

dlang-bot merged 1 commit into
dlang:masterfrom
wilzbach:silent-version

Conversation

@wilzbach

@wilzbach wilzbach commented Sep 3, 2020

Copy link
Copy Markdown
Contributor

The exact compiler version breaks AUTO_UPDATE and also will require unnecessary updates to frontend.h.

See also: #11679 (comment)

@dlang-bot

Copy link
Copy Markdown

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11680"

@UplinkCoder

Copy link
Copy Markdown
Member

why does this break anything?

@MoonlightSentinel

Copy link
Copy Markdown
Contributor
  • The generated frontend.h will change with every new release due to this comment.
  • compilable/dtoh_***.d use $n$ to avoid this problem but AUTO_UPDATE overwrites special sequences

@wilzbach

wilzbach commented Sep 3, 2020

Copy link
Copy Markdown
Contributor Author

(+ also when people eventually start to generate headers like we do with frontend.h they will run into the same problems).

@MoonlightSentinel

Copy link
Copy Markdown
Contributor

This change should probably be listed in the existing changelog entry.

@wilzbach

wilzbach commented Sep 3, 2020

Copy link
Copy Markdown
Contributor Author

This change should probably be listed in the existing changelog entry.

Nah. This is implementation detail.

@MoonlightSentinel

Copy link
Copy Markdown
Contributor

Fair enough

@MoonlightSentinel MoonlightSentinel added Merge:auto-merge Review:Trivial typos, formatting, comments labels Sep 3, 2020
@wilzbach
wilzbach deleted the silent-version branch September 3, 2020 20:14
@ibuclaw ibuclaw added the Feature:dtoh C++ header generation label Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:dtoh C++ header generation Merge:auto-merge Review:Trivial typos, formatting, comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants