Use asyncio.run in StatelessServer.run#561
Open
puneetdixit200 wants to merge 1 commit into
Open
Conversation
2d669c6 to
7447fc9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StatelessServer.run()currently callsasyncio.get_event_loop()before runningarun(). On Python 3.14, a fresh main thread may not have a current event loop, so this raises before the server can start.This switches the synchronous entry point to
asyncio.run(self.arun()), which creates and manages the loop for this one-shot runner. I also added a regression test that patchesasyncio.get_event_loop()to raise with the Python 3.14-style failure and confirmsrun()still reaches the handler.Refs #559.
Tests:
.venv\Scripts\python -m pytest tests\test_server.py::test_run_creates_event_loop_when_none_exists -q.venv\Scripts\python -m pytest tests\test_server.py -q.venv\Scripts\python -m pytest -q.venv\Scripts\python -m mypy .git diff --check