Skip to content

fix: extra padding on bottom #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
divyanshu-patil merged 3 commits into from
Jan 22, 2026
Merged

fix: extra padding on bottom #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a92568f
fix: extra padding at bottom
divyanshu-patil Jan 22, 2026
f6bc987
fix: added missing files in commit
divyanshu-patil Jan 22, 2026
824806d
refactor: added border in editor styling for example
divyanshu-patil Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions example/ios/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2449,7 +2449,7 @@ PODS:
- React-perflogger (= 0.83.0)
- React-utils (= 0.83.0)
- SocketRocket
- ReactNativeTypeRich (2.2.0):
- ReactNativeTypeRich (2.2.1):
- boost
- DoubleConversion
- fast_float
Expand Down Expand Up @@ -2802,7 +2802,7 @@ SPEC CHECKSUMS:
ReactAppDependencyProvider: ebcf3a78dc1bcdf054c9e8d309244bade6b31568
ReactCodegen: 11c08ff43a62009d48c71de000352e4515918801
ReactCommon: 424cc34cf5055d69a3dcf02f3436481afb8b0f6f
ReactNativeTypeRich: 6574bc6206275e1afce4d8defa6d1bde7443e738
ReactNativeTypeRich: 86e81019b5200d62bc5995ab15d75ebaef081779
SocketRocket: d4aabe649be1e368d1318fdf28a022d714d65748
Yoga: 6ca93c8c13f56baeec55eb608577619b17a4d64e

Expand Down
5 changes: 3 additions & 2 deletions example/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,8 +470,9 @@ const styles = StyleSheet.create({
backgroundColor: 'gainsboro',
// fontSize: 34,
fontFamily: 'Nunito-Regular',
// paddingVertical: 12,
// paddingHorizontal: 14,
paddingVertical: 12,
paddingHorizontal: 14,
borderWidth: 2,
},
scrollPlaceholder: {
marginTop: 24,
Expand Down
15 changes: 1 addition & 14 deletions ios/TypeRichTextInputView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@

#pragma mark - Implementation

@implementation TypeRichTextInputView {

Check warning on line 35 in ios/TypeRichTextInputView.mm

View workflow job for this annotation

GitHub Actions / build-ios 

class 'TypeRichTextInputView' does not conform to protocol 'RCTTypeRichTextInputViewViewProtocol' [-Wprotocol]

Check warning on line 35 in ios/TypeRichTextInputView.mm

View workflow job for this annotation

GitHub Actions / build-ios 

class 'TypeRichTextInputView' does not conform to protocol 'RCTTypeRichTextInputViewViewProtocol' [-Wprotocol]
/// Native text input
UITextView *_textView;

Expand Down Expand Up @@ -130,7 +130,7 @@
_disableImagePasting = NO;

// Add textView as subview (not contentView)
[self addSubview:_textView];
self.contentView = _textView;

[self updatePlaceholderVisibility];
}
Expand Down Expand Up @@ -447,7 +447,7 @@
}

// Apply to existing text
NSMutableAttributedString *attributedText =

Check warning on line 450 in ios/TypeRichTextInputView.mm

View workflow job for this annotation

GitHub Actions / build-ios 

unused variable 'attributedText' [-Wunused-variable]

Check warning on line 450 in ios/TypeRichTextInputView.mm

View workflow job for this annotation

GitHub Actions / build-ios 

unused variable 'attributedText' [-Wunused-variable]
[[NSMutableAttributedString alloc]
initWithString:_textView.text ?: @""
attributes:attributes];
Expand Down Expand Up @@ -753,19 +753,6 @@
_placeholderLabel.hidden = _textView.text.length > 0;
}

- (void)layoutSubviews {
[super layoutSubviews];

// Ensure text view fills the parent bounds
_textView.frame = self.bounds;

// Debug: Log frame and content size
NSLog(@"TextView frame: %@, contentSize: %@, maxLines: %ld",
NSStringFromCGRect(_textView.frame),
NSStringFromCGSize(_textView.contentSize),
(long)_textView.textContainer.maximumNumberOfLines);
}

#pragma mark - Event emitter

- (std::shared_ptr<TypeRichTextInputViewEventEmitter>)getEventEmitter {
Expand Down
Loading