Skip to content

Scientific Consistency and Framework Restructuring#16

Merged
divyang4481 merged 1 commit into
mainfrom
scientific-consistency-and-restructuring-9364016472972784613
Jun 7, 2026
Merged

Scientific Consistency and Framework Restructuring#16
divyang4481 merged 1 commit into
mainfrom
scientific-consistency-and-restructuring-9364016472972784613

Conversation

@divyang4481

Copy link
Copy Markdown
Owner

This PR implements a comprehensive update to the X-Theta framework to ensure scientific discipline and notation consistency.

Key changes:

  1. Notation Standardization: Throughout the xtheta/ package, tests/, and notebooks, we now strictly use Phi (capital) for the physical relational phase/holonomy and delta (lowercase) for phenomenological detector phase shifts.
  2. Formula Correction: Ensured that the physical X-Theta CHSH maximum uses the basis-optimized Horodecki formula $S_{\max}(\Phi) = 2\sqrt{1 + \cos^2(2\Phi)}$.
  3. Notebook Restructuring:
    • Renumbered notebooks to a clean 01-08 sequence.
    • Merged the two Hensen data audit notebooks into a single canonical 06_hensen_open_data_audit.ipynb.
    • Updated 07_synthetic_phase_recovery.ipynb to include two distinct models: Model A (detector shift using delta) and Model B (physical tensor anisotropy using Phi).
  4. Scientific Framing:
    • Added 'Scientific Scope' warning blocks to the top of all relevant notebooks.
    • Updated notebook conclusions to explicitly classify results into Mathematical Validation, Simulation/Benchmark, Open-Data Pipeline Validation, Phenomenological Fit, or Physical Prediction.
    • Explicitly framed Earth-orbit (Micius/GPS) benchmarks as null-regime consistency checks and Hensen audits as pipeline validation only.
  5. Documentation: Updated the paper_1_kinematic_framework/outline.md to reflect the new 9-section structure and included a notebook traceability table.
  6. Code Maintenance: Renamed internal files and updated imports (e.g., phi_eff_fit.py -> Phi_eff_fit.py) to align with the new notation.

All 47 unit tests passed after these widespread changes.


PR created automatically by Jules for task 9364016472972784613 started by @divyang4481

- Standardized notation: Phi (capital) for physical X-Theta phase, delta (lowercase) for detector shifts.
- Updated CHSH formulas: Smax uses Horodecki maximum 2*sqrt(1+cos^2(2*Phi)).
- Renumbered notebooks (01-08) and merged Hensen audits into canonical 06_hensen_open_data_audit.
- Updated 07_synthetic_phase_recovery to distinguish between detector-shift (delta) and tensor-anisotropy (Phi) models.
- Audited xtheta/ package and tests/ for notation consistency.
- Added mandatory 'Scientific Scope' warnings and claim classifications to all notebooks.
- Updated paper 1 outline.md with new structure and notebook traceability.
- Renamed phi_eff_fit.py to Phi_eff_fit.py.
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@divyang4481 divyang4481 merged commit 207c4d0 into main Jun 7, 2026
1 check passed
@divyang4481 divyang4481 deleted the scientific-consistency-and-restructuring-9364016472972784613 branch June 7, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant