Scientific Consistency and Framework Restructuring#16
Conversation
- Standardized notation: Phi (capital) for physical X-Theta phase, delta (lowercase) for detector shifts. - Updated CHSH formulas: Smax uses Horodecki maximum 2*sqrt(1+cos^2(2*Phi)). - Renumbered notebooks (01-08) and merged Hensen audits into canonical 06_hensen_open_data_audit. - Updated 07_synthetic_phase_recovery to distinguish between detector-shift (delta) and tensor-anisotropy (Phi) models. - Audited xtheta/ package and tests/ for notation consistency. - Added mandatory 'Scientific Scope' warnings and claim classifications to all notebooks. - Updated paper 1 outline.md with new structure and notebook traceability. - Renamed phi_eff_fit.py to Phi_eff_fit.py.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR implements a comprehensive update to the X-Theta framework to ensure scientific discipline and notation consistency.
Key changes:
xtheta/package,tests/, and notebooks, we now strictly usePhi(capital) for the physical relational phase/holonomy anddelta(lowercase) for phenomenological detector phase shifts.06_hensen_open_data_audit.ipynb.07_synthetic_phase_recovery.ipynbto include two distinct models: Model A (detector shift usingdelta) and Model B (physical tensor anisotropy usingPhi).paper_1_kinematic_framework/outline.mdto reflect the new 9-section structure and included a notebook traceability table.phi_eff_fit.py->Phi_eff_fit.py) to align with the new notation.All 47 unit tests passed after these widespread changes.
PR created automatically by Jules for task 9364016472972784613 started by @divyang4481