Skip to content

Fix Hensen Open-Data Pipeline and CHSH Validation#13

Merged
divyang4481 merged 1 commit into
mainfrom
fix-hensen-data-pipeline-2779392400303516599
Jun 7, 2026
Merged

Fix Hensen Open-Data Pipeline and CHSH Validation#13
divyang4481 merged 1 commit into
mainfrom
fix-hensen-data-pipeline-2779392400303516599

Conversation

@divyang4481

Copy link
Copy Markdown
Owner

The Hensen dataset adapter was previously using incorrect column mappings and lacked the necessary heralding filters, leading to an unphysical S-statistic and incorrect trial counts. I have updated xtheta/data/adapters/hensen.py to implement the official filtering logic described in the 2015 Nature paper. This includes:

  • Applying event_ready window filters and channel coincidence checks.
  • Implementing signal integrity filters (invalid markers and post-excitation clicks).
  • Mapping CHSH settings to the correct random number columns.
  • Deriving outcomes from readout window timing.

These changes result in a valid Bell-test dataset of 245 trials with S ≈ 2.4225, matching the published Delft results. I also updated the validation outputs in xtheta-lab/outputs/.


PR created automatically by Jules for task 2779392400303516599 started by @divyang4481

- Implemented official filtering logic (heralding, signal integrity) from Hensen et al. 2015.
- Corrected column mapping for CHSH settings and outcomes.
- Verified final trial count (245) and CHSH S-statistic (~2.42) against published results.
- Updated validation reports and summary data.
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@divyang4481 divyang4481 merged commit 436fa3b into main Jun 7, 2026
1 check passed
@divyang4481 divyang4481 deleted the fix-hensen-data-pipeline-2779392400303516599 branch June 7, 2026 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant