Fix Hensen Open-Data Pipeline and CHSH Validation#13
Conversation
- Implemented official filtering logic (heralding, signal integrity) from Hensen et al. 2015. - Corrected column mapping for CHSH settings and outcomes. - Verified final trial count (245) and CHSH S-statistic (~2.42) against published results. - Updated validation reports and summary data.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
The Hensen dataset adapter was previously using incorrect column mappings and lacked the necessary heralding filters, leading to an unphysical S-statistic and incorrect trial counts. I have updated
xtheta/data/adapters/hensen.pyto implement the official filtering logic described in the 2015 Nature paper. This includes:event_readywindow filters and channel coincidence checks.These changes result in a valid Bell-test dataset of 245 trials with S ≈ 2.4225, matching the published Delft results. I also updated the validation outputs in
xtheta-lab/outputs/.PR created automatically by Jules for task 2779392400303516599 started by @divyang4481