Repository navigation
Slim Visualize instructions and shared-rule references - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Visualize's entrypoint repeats trigger examples and procedural explanations, while several references repeat shared rules. Condense the entrypoint in place and have creation, polish, and review defer to the existing shared contracts where their guidance overlaps.
visualize/SKILL.mdshrinks from 29,797 to 25,549 bytes (14.3%); its description shrinks from 917 to 381 characters. Entry headings, commands, permissions, absolute bans, model-specific rules, universal laws, and the creation shape gate are retained. Theme alternatives remain conditional on the user asking for alternatives.Creation starts candidate-template selection from names, descriptions, and use/exclusion sections, with further sections available when structural fit is uncertain. The selected template's complete contract is still required before composing. Report, Comparison, and Research brief now expose distinct selection criteria: prose-led findings with ordinary evidence tables; a qualitative state-and-value matrix; and research-source synthesis or study documentation. Selection-critical conditions move up from deeper guidance without duplicating their full rules. Canonical changes and all three mirrors are committed together; scripts and package/catalog architecture are unchanged.
Validation at
8e6b020:CI passed on run 39434297241, attempt 2 at
8e6b020. Only the failedvalidatejob was retried; the successfulmermaid-windowsresult was retained. The first attempt failed in the unchanged image-route testCLI waits for SIGKILL and close before timeout cleanup(image-routes.test.mjs:93), whose 5 ms timeout/grace window expectedbridge-timeoutbut receivedbridge-termination-unconfirmed. It passed unmodified on retry; the same complete 59-test image suite also passed locally. No image-route source or test changes were made.Earlier independent Opus semantic-review findings were addressed. Previous behavioral trials covered shape approval, theme alternatives, motion-none handling, and bounded/no-op refinement; the fresh tests above exercise the current template-selection changes.
The generic skill-creator validator rejects the pre-existing
version,user-invocable, andargument-hintfields on both the original and revised skill. Those host fields are preserved. Raw tool-event excerpts, transcript hashes, artifact comparisons, screenshots, and CI/local logs are retained locally undertemp/slimming-evaluation/template-selection-content/.