Proper implementation of OffsetDateTime.toJava, LocalTime.fromJava, and LocalTime#toJava methods#1928
Open
plokhotnyuk wants to merge 1 commit into
Open
Conversation
plokhotnyuk
force-pushed
the
series/0.19
branch
from
04f711e to
1541f01
Compare
…eTime.toJava`, `LocalTime.fromJava`, and `LocalTime#toJava` methods
plokhotnyuk
force-pushed
the
series/0.19
branch
from
1541f01 to
c857867
Compare
lewisjkl
approved these changes
Apr 28, 2026
lewisjkl
reviewed
Apr 28, 2026
Contributor
lewisjkl
left a comment
lewisjkl
left a comment
There was a problem hiding this comment.
Looks good, if you don't mind adding a test case to prevent future regression, that'd be great as well
Member
|
yeah, I'd appreciate some tests cases as well, it's hard to see what makes these proper otherwise :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1917