Sourcery refactored main branch

[sourcery-ai]

Branch main refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

• VS Code
• PyCharm

Review changes via command line

To manually merge these changes, make sure you're on the main branch, then run:

git fetch origin sourcery/main
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

[sourcery-ai]

Function Order.shipping refactored with the following changes:

• Use any() instead of for loop (use-any)
• Inline variable that is immediately returned (inline-immediately-returned-variable)

[sourcery-ai]

Function Order.get_cart_total refactored with the following changes:

• Replace unneeded comprehension with generator (comprehension-to-generator)
• Inline variable that is immediately returned (inline-immediately-returned-variable)

[sourcery-ai]

Function Order.get_cart_items refactored with the following changes:

• Replace unneeded comprehension with generator (comprehension-to-generator)
• Inline variable that is immediately returned (inline-immediately-returned-variable)

[sourcery-ai]

Function OrderItem.get_total refactored with the following changes:

• Inline variable that is immediately returned (inline-immediately-returned-variable)

[sourcery-ai]

Function cookieCart refactored with the following changes:

• Use items() to directly unpack dictionary values (use-dict-items)

[sourcery-ai]

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.72%.

Quality metrics	Before	After	Change
Complexity	2.42 ⭐	2.37 ⭐	-0.05 👍
Method Length	31.93 ⭐	31.07 ⭐	-0.86 👍
Working memory	6.77 🙂	6.83 🙂	0.06 👎
Quality	78.48% ⭐	77.76% ⭐	-0.72% 👎

Other metrics	Before	After	Change
Lines	126	119	-7

Changed files	Quality Before	Quality After	Quality Change
ecommerce/store/models.py	95.40% ⭐	98.39% ⭐	2.99% 👍
ecommerce/store/utils.py	67.32% 🙂	67.22% 🙂	-0.10% 👎

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
ecommerce/store/utils.py	cookieCart	6 ⭐	135 😞	10 😞	58.64% 🙂	Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!