simplify "pinned" / "starred" language in UI#757
Open
marcustyphoon wants to merge 1 commit into
Open
Conversation
Contributor
|
Deployed preview build to Cloudflare!
|
marcustyphoon
force-pushed
the
character-local-storage-ui-tweak
branch
from
aa2807d to
9dab79d
Compare
marcustyphoon
force-pushed
the
character-local-storage-ui-tweak
branch
from
9dab79d to
ab192cf
Compare
marcustyphoon
force-pushed
the
character-local-storage-ui-tweak
branch
from
ab192cf to
edf3ccb
Compare
marcustyphoon
force-pushed
the
character-local-storage-ui-tweak
branch
from
edf3ccb to
e44cd8b
Compare
marcustyphoon
force-pushed
the
character-local-storage-ui-tweak
branch
from
e44cd8b to
a2a02e7
Compare
marcustyphoon
force-pushed
the
character-local-storage-ui-tweak
branch
from
a2a02e7 to
c460790
Compare
marcustyphoon
force-pushed
the
character-local-storage-ui-tweak
branch
from
c460790 to
34d1f1a
Compare
marcustyphoon
force-pushed
the
character-local-storage-ui-tweak
branch
from
34d1f1a to
569dbe4
Compare
marcustyphoon
force-pushed
the
character-local-storage-ui-tweak
branch
from
569dbe4 to
411460b
Compare
marcustyphoon
force-pushed
the
character-local-storage-ui-tweak
branch
from
411460b to
ce81fd3
Compare
marcustyphoon
force-pushed
the
character-local-storage-ui-tweak
branch
from
ce81fd3 to
b8ae16c
Compare
marcustyphoon
force-pushed
the
character-local-storage-ui-tweak
branch
from
b8ae16c to
1a16bfd
Compare
marcustyphoon
force-pushed
the
character-local-storage-ui-tweak
branch
from
1a16bfd to
48abd1b
Compare
marcustyphoon
force-pushed
the
character-local-storage-ui-tweak
branch
from
48abd1b to
68833bb
Compare
marcustyphoon
force-pushed
the
character-local-storage-ui-tweak
branch
from
68833bb to
d27d5d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The terminology of different kind of saved results gets a bit confusing in the local storage PR.
Here's an idea about how to make it clearer: we could always use "save" to refer to saving builds to local storage, and always refer to the temporary storage as "pinning" (a word that generally implies that something is being kept around for a particular purpose temporarily).
(On the other hand, I bet some people would prefer it if we didn't make a distinction at all and just persisted all starred builds to local storage. This would prevent people from losing results when they closed the page without manually going into the menu, but it would clutter the main UI—and screenshots of it—for power users with a lot of saved builds.)