Local Storage for builds#441
Open
gw2princeps wants to merge 51 commits into
Open
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
|
This is ready in theory. One thing that is up for discussion is the handling of dual wielded weapons in the result tables. Since we can restore builds with a different option on dual/single wield, the table will bug out. |
Member
|
Hm. We could make the table always have 2 weapon rows and span them if you have a single weapon I guess. Looks kind of weird though. More advanced logic could do that if any build has 2 weapons maybe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes / additions: