Skip to content

Local Storage for builds#441

Open
gw2princeps wants to merge 51 commits into
mainfrom
feat/character-local-storage
Open

Local Storage for builds#441
gw2princeps wants to merge 51 commits into
mainfrom
feat/character-local-storage

Conversation

@gw2princeps

@gw2princeps gw2princeps commented Apr 11, 2022

Copy link
Copy Markdown
Member

Changes / additions:

  • Saved results are permanently shown now; maybe this brings more attention to this feature.
  • A button to open the saved results manager was added
  • The manager allows a number of things:
    • Saving a character to the local storage
    • downloading characters
    • copying characters to the clipboard
    • a nice overview over all the saved builds :))
    • Renaming a character to keep track of own builds more easily

@cloudflare-workers-and-pages

This comment was marked as outdated.

@gw2princeps

Copy link
Copy Markdown
Member Author

This is ready in theory. One thing that is up for discussion is the handling of dual wielded weapons in the result tables. Since we can restore builds with a different option on dual/single wield, the table will bug out.

@marcustyphoon

Copy link
Copy Markdown
Member

Hm. We could make the table always have 2 weapon rows and span them if you have a single weapon I guess. Looks kind of weird though. More advanced logic could do that if any build has 2 weapons maybe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants