data: Add power block trait with severance correlation#1017
Draft
marcustyphoon wants to merge 2 commits into
Draft
data: Add power block trait with severance correlation#1017marcustyphoon wants to merge 2 commits into
marcustyphoon wants to merge 2 commits into
Conversation
Contributor
|
Deployed build to Cloudflare!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if I want to actually add this. Is this too confusing? You have to enter three values for power block if you have severance sigil on (1/40/20, in the case of interrupting every 10 seconds).
Clearly I need to just throw away the idea that the dataset is in a non-executable file that can hypothetically be used in other projects and just make the thing a js file, allowing arbitrary code in modifier definitions so they can do arbitrarily complicated things based on simple inputs. But... eugh. Ensuring a modifier doesn't straight up crash the optimizer is a lot harder if you do that.
[draft previews]