[test PR]#1003
Open
marcustyphoon wants to merge 2 commits into
Open
Conversation
Contributor
|
Deployed build to Cloudflare!
|
Member
Author
|
We do not. hm. may be a difference in default |
Deploying optimizer with
|
| Latest commit: |
9271e8f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://58a68d2a.discretize-gear-optimizer.pages.dev |
| Branch Preview URL: | https://ksjfsdjnfs.discretize-gear-optimizer.pages.dev |
Member
Author
|
Aha! Cloudflare automatically comments (presumably because the cloudflare github app is installed in this organization?) only if you deploy the PR head commit, not the PR merge commit. I assume they're firing code on any deployment that checks if the deployed commit is a PR head and comments on that PR if so. Generally speaking, it makes sense to run CI on (test and deploy) the PR merge commit, so I think this is kind of a bug. Maybe I'll try to find where to report this. |
This was referenced Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Empty commit to test the deploy workflow. Do we get a cloudflare bot comment like #999 did? Did this suddenly change?