Fix form construction for D11.

[adam-vessey]

Summary by CodeRabbit

• Refactor
  • Improved internal dependency injection patterns in form components for enhanced code maintainability.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e1756121-359e-4d3d-83f5-bc1792103f4b

📥 Commits

Reviewing files that changed from the base of the PR and between c9eda1d and 581428e.

📒 Files selected for processing (2)

• src/Form/CheckForm.php
• src/Form/SettingsForm.php

---

📝 Walkthrough

Walkthrough

Two form classes refactor from constructor dependency injection to Drupal's container-based factory pattern with fluent setters. CheckForm wires the fixity service; SettingsForm wires entity type manager and state. Unused constructor imports are removed from both files.

Changes

Dependency Injection Refactoring

Layer / File(s)	Summary
CheckForm DI refactoring src/Form/CheckForm.php	Constructor-based fixity service injection replaced with container-driven create() factory and setFixity() fluent setter. Unused constructor dependency imports removed.
SettingsForm DI refactoring src/Form/SettingsForm.php	Constructor-based dependency injection for ConfigFactoryInterface, EntityTypeManagerInterface, and StateInterface replaced with container-driven create() factory and fluent setters setEntityTypeManager() and setState(). Unused ConfigFactoryInterface import removed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Two forms take the container's hand,
Dancing away from constructor's demand,
Fluent setters whisper their grace,
Factory methods take their place.
Cleaner imports, patterns refined,
Dependency joy, aligned by design! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'Fix form construction for D11' is vague and generic, using non-descriptive terms that don't clearly convey the specific nature of the changes.	Consider a more specific title that describes the actual refactoring, such as 'Refactor form dependency injection to use fluent setters' or 'Convert form constructors to use container-based injection'.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/d11-forms

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 PHPStan (2.2.1)

Composer install failed: dependency resolution error. Check composer.json and composer.lock for version constraints.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Tag generated by PR: v1.4.6