Skip to content

Update target and focus behavior#14

Open
mzlock wants to merge 2 commits into
mainfrom
update-focus-behavior
Open

Update target and focus behavior#14
mzlock wants to merge 2 commits into
mainfrom
update-focus-behavior

Conversation

@mzlock

@mzlock mzlock commented May 16, 2023

Copy link
Copy Markdown
Contributor
  • updates the targeting and focus utils to include some changes made to another copy
    • use promises and await when getting new prev/next drop targets
    • FocusManager can take a getActiveElement option
  • removes this.actions.publishDragSource() in handleDragStart -- this seemed to be publishing an old copy of the drag source, which caused some positioning issues when an item was dragged more than once

@mzlock mzlock requested a review from faultyserver May 16, 2023 14:33
@mzlock mzlock marked this pull request as ready for review May 16, 2023 14:33
@mzlock

mzlock commented Sep 29, 2023

Copy link
Copy Markdown
Contributor Author

Will come back to this work soon. I still need to:

  • remove yarn stuff, since this uses pnpm now
  • double-check that removing this.actions.publishDragSource(); won't break things for other apps using the library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant