build!: don't vendor dependencies#225
Open
gabemeola wants to merge 1 commit into
Open
Conversation
Contributor
|
This is great! Thanks for the breakdown. I'm curious when would be the best time to land this. Possibly makes sense as a part of any 2.0-related work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependencies are referrenced from
node_modulesor Yarn Plug'n'Play instead of vendoring within this bundle.This shaves 130KiB off the gzip tar or ~700KiB uncompressed tar.
This is better for the npm ecosystem but could break consumers which had malformed
node_modules(or were doing something custom such as pnpm overrides)Before
tree -l 1000 --base ./output/npm packAfter
tree -l 1000 --base ./output/npm pack