fix: observation title truncated#1890
Merged
Merged
Conversation
…ItemLayout optimization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1873
Changes
Removes fixed height from observation list so also have to remove getItemLayout optimization.
The reason we had fixed height was so that we could use this https://reactnative.dev/docs/flatlist#getitemlayout.
getItemLayout matters most when users scroll quickly through large lists — without it, FlatList has to measure every item lazily as it comes into view, which can cause blank frames and weirdness on fast scrolls.
So this is what it had looked like for some with large fonts:
However, even if we picked a super large magic number for height to allow for the most narrow of phones and the largest text (so we would have fixed height list items and could use getItemLayout) that doesn't seem like it would be optimal behavior. For most people the observation item would be too big. And even if we made it really big, for some it would still be too small.
So, instead, I opted to get rid of the getItemLayout feature and instead use a minHeight of 80 pixels. Now the height of each list item is variable depending on the content.
Please let me know if you would rather go a different way.